first try: add libravatarFallback #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MVP. still missing: - settings.showLibravatarAvatars - discovering selfhosted libravatar via SRV records https://wiki.libravatar.org/api/
justjanne
requested changes
Oct 23, 2019
app/src/test/java/de/kuschku/quasseldroid/util/AvatarHelperTest.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still missing:
SRVtargeting_avatars-sec._tcpondomain(and possibly_avatars._tcpfor plain HTTP fallback?). i don't know what imports/syntax are necessary to do this (dnsjava? minidns?), so i have only added the base url and domain split; someone else can add the try-except for SRV lookup.also not sure if the test is correct; i didn't know which settings to include so i would appreciate a review on f1baabd particularly. also 04d10c6 should say
values-it stringsinstead ofvalues-fr-rCA stringsbut i forgot to change the commit title when copypasting.If any other changes are needed that I missed, please let me know as I have never worked with Android / Java / Kotlin before, so I just did a search for "gravatar" in this repo and copied/adapted what i could find.