Adding completion for https://github.com/swissquote/carnotzet #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This goes beyond the scope of this project imho. We can take the completion of the maven plugin only if you change the PR. |
|
Alright, so I just skip the docker-compose part? And fix the conflict... |
mosabua
reviewed
Apr 21, 2020
bash_completion.bash
Outdated
| @@ -185,6 +192,7 @@ _mvn() | |||
| local plugin_goals_spring_boot="spring-boot:run|spring-boot:repackage" | |||
| local plugin_goals_jgitflow="jgitflow:feature-start|jgitflow:feature-finish|jgitflow:release-start|jgitflow:release-finish|jgitflow:hotfix-start|jgitflow:hotfix-finish|jgitflow:build-number" | |||
| local plugin_goals_wildfly="wildfly:add-resource|wildfly:deploy|wildfly:deploy-only|wildfly:deploy-artifact|wildfly:redeploy|wildfly:redeploy-only|wildfly:undeploy|wildfly:undeploy-artifact|wildfly:run|wildfly:start|wildfly:shutdown|wildfly:execute-commands" | |||
| local plugin_goals_zet="addrs|clean|crawl|help|logs|ps|pull|restart|run|shell|start|stop|welcome" | |||
There was a problem hiding this comment.
Just have this specific line but add the right prefix..
mosabua
reviewed
Apr 21, 2020
bash_completion.bash
Outdated
| @@ -202,7 +210,24 @@ _mvn() | |||
|
|
|||
| local IFS=$'|\n' | |||
|
|
|||
| if [[ ${cur} == -D* ]] ; then | |||
| if [[ ${words[1]} == zet:* ]] ; then | |||
mosabua
reviewed
Apr 21, 2020
bash_completion.bash
Outdated
| @@ -118,7 +125,7 @@ _mvn() | |||
| COMPREPLY=() | |||
| POM_HIERARCHY=() | |||
| __pom_hierarchy | |||
| _get_comp_words_by_ref -n : cur prev | |||
| _get_comp_words_by_ref -n := cur prev words | |||
mosabua
reviewed
Apr 21, 2020
bash_completion.bash
Outdated
| @@ -46,6 +46,13 @@ __ltrim_colon_completions() | |||
| fi | |||
| } | |||
|
|
|||
| __docker_compose_services() | |||
|
Might be worth just creating a new PR if you dont want to muck around with rebasing.. |
|
@mosabua like that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.