C# Async with .NET Core Kaitai.Struct.Runtime.Async #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t class constructor visibility to protected.
pluskal
force-pushed
the
Async
branch
2 times, most recently
from
347a849 to
f0dca07
Compare
Add Async support to Runtime Closes #1 See merge request marta/kaitai_struct_csharp_runtime!3
Pipe reader See merge request marta/kaitai_struct_csharp_runtime!7
…ad' into 'master' Resolve "Ensure that ReadResult is not default before first read." Closes kaitai-io#4 See merge request marta/kaitai_struct_csharp_runtime!9
…tion to _readerContext.
…ls' into 'master' Resolve "Position should remain the same on Size, Pos, IsEof calls" Closes kaitai-io#5 See merge request marta/kaitai_struct_csharp_runtime!11
pluskal
changed the title
Resolve "`Nullable<T>` for optional fields are call" Closes kaitai-io#6 See merge request marta/kaitai_struct_csharp_runtime!14
…ster' Resolve "ImplicitNullable fails during serialization." Closes kaitai-io#7 See merge request marta/kaitai_struct_csharp_runtime!16
…lemement-advance' into 'master' Resolve "KaitaiStreamAsync encapsulating pipereader should implemement Advance" Closes kaitai-io#8 See merge request marta/kaitai_struct_csharp_runtime!18
Resolve "Add CancellationToken support." Closes kaitai-io#9 See merge request marta/kaitai_struct_csharp_runtime!19
…-ends-with-exception' into 'master' Resolve "Forward PipeReader.SeekAsync on completed ReadResult ends with exception" Closes kaitai-io#10 See merge request marta/kaitai_struct_csharp_runtime!20
…o-examined-the-whole-buffer' into 'master' Resolve "Fix PipeReaderContext.ReadByteAsync should advance to examined the whole buffer" Closes kaitai-io#11 See merge request marta/kaitai_struct_csharp_runtime!21
… deprecation warning message - generalmimon committed on Apr 26, 2020
…30e4 - generalmimon committed on Apr 27, 2020
Rebase on 0.9 See merge request marta/kaitai_struct_csharp_runtime!22
…am-ikaitaistreambase' into 'master' Resolve "Update Exceptions to use interfaces IKaitaiAsyncStream, IKaitaiStreamBase" Closes kaitai-io#12 See merge request marta/kaitai_struct_csharp_runtime!23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to kaitai-io/kaitai_struct#640 and kaitai-io/kaitai_struct_compiler#189
This PR adds an additional unit tests that ensures correct behavior of the runtime itself that is not dependent on the compiled KSY files.
An abstraction formed by
IKaitaiStreamBase,IKaitaiAsyncStreamis introduced to decouple code and implementation to allow reimplementation of the Stream if needed. (I was unable to update the compiler to accept interface instead of direct type due to my lack of Scala knowledge and coupling in the compiler and translator code.)The ultimate goal is to introduce Asynchronous implementation that allows usage in massively parallel applications that consumes data in async streams. To achieve that,
IReaderContextis introduced to abstract multiple implementations of the "Stream".StreamReaderContextthat suffers from a lack of asynchronicity due to the .NET'sStreamAPI that does not support asynchronous seek operation.PipeReaderContext.The folder structure, project naming is changed to reflect C#/.NET conventions.