Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type definition to be able to run on lower PHP versions #13095

Open
wants to merge 3 commits into
base: Ursa-21.8.0
Choose a base branch
from
Open

Remove type definition to be able to run on lower PHP versions #13095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98a2870
Remove type definition to be able to run on lower PHP versions
yossipapi Jan 24, 2025
1ca9812
Syntaxt unsupported by older php versions
yossipapi Jan 24, 2025
a8f886b
Syntax unsupported by older php versions
yossipapi Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions plugins/reach/lib/model/data/kClipsVendorTaskData.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,10 @@
*/
class kClipsVendorTaskData extends kVendorTaskData
{
public int $clipsDuration = 0;

public ?string $eventSessionContextId = null;

public string $instruction = "";

public ?string $clipsOutputJson = null;
public $clipsDuration = 0;
public $eventSessionContextId = null;
public $instruction = "";
public $clipsOutputJson = null;

public function getClipsDuration(): int
{
Expand Down
12 changes: 6 additions & 6 deletions plugins/reach/lib/model/data/kQuizVendorTaskData.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
*/
class kQuizVendorTaskData extends kVendorTaskData
{
public int $numberOfQuestions = 0;
public ?string $questionsType = null;
public string $context = "";
public ?string $formalStyle = null;
public bool $createQuiz = True;
public ?string $quizOutput = null;
public $numberOfQuestions = 0;
public $questionsType = null;
public $context = "";
public $formalStyle = null;
public $createQuiz = True;
public $quizOutput = null;

public function getNumberOfQuestions(): int
{
Expand Down
13 changes: 5 additions & 8 deletions plugins/reach/lib/model/data/kSummaryVendorTaskData.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,10 @@
*/
class kSummaryVendorTaskData extends kVendorTaskData
{
protected String $typeOfSummary;

protected String $writingStyle;

protected ?String $language;

protected ?string $summaryOutputJson = null;
protected $typeOfSummary;
protected $writingStyle;
protected $language;
protected $summaryOutputJson = null;

public function __construct()
{
Expand Down Expand Up @@ -60,4 +57,4 @@ public function setSummaryOutputJson(?string $summaryOutputJson): void
{
$this->summaryOutputJson = $summaryOutputJson;
}
}
}