-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5 Allow printing report to a JSON file #14
base: master
Are you sure you want to change the base?
Conversation
the destination folder of the `report.json` file: | ||
|
||
```xml | ||
<properties> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paleloser Could we move these properties to extension parameters? Is that possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe maven extensions don't allow parameters, as they don't work with Mojos: http://maven.apache.org/examples/maven-3-lifecycle-extensions.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically you could use a system property ....?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved at 7e586f1.
I would wait for #15 |
@paleloser Since my PR #15 was recently merged, sync with |
…e-profiler into output-to-json
PR#15 has been merged. |
@paleloser Could you address the pending things here? |
@khmarbaise PR is ready to be merged |
Motivation
As discussed in #5 , the purpose of this PR is to make the extension configurable in order to select wether to print the report via stdout or to a JSON file.
Plan
This feature accepts 2 maven properties:
<maven-buildtime-profiler.output>
: optional, used to select betweenstdout
,none
orjson
output.<maven-buildtime-profiler.directory>
: optional, used to select the destination folder of thereport.json
fileBy default, the extension works as it used to, printing the output to the console. If json output is set, the default destination folder is the project's base directory.
An example of the output would be:
Note that te units are the same as the original report: milliseconds for time, mebibytes per second for rate and bytes for sizes.
Acceptance criteria
json
andstdout
, beingstdout
the default one