Optimize Latent Caching Speed with VAE Optimizations #1910
+26
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Summary: This PR accelerates latent caching, a slow preprocessing step, by optimizing the VAE's encoding process. Key Changes: Mixed Precision Caching: VAE encoding now uses FP16 (or BF16) during latent caching for faster computation and reduced memory use. Channels-Last VAE: VAE is temporarily switched to channels_last memory format during caching to improve GPU performance. --vae_batch_size Utilization: This leverages the existing --vae_batch_size option; users should increase it for further speedups. Benefits: Significantly Faster Latent Caching: Reduces preprocessing time. Improved GPU Efficiency: Optimizes VAE encoding on GPUs. Impact: Faster training setup due to quicker latent caching. This is much more concise and directly highlights the essential changes and their impact. Let me know if you would like it even shorter or with any other adjustments! Based on the optimizations implemented—mixed precision and channels-last format for the VAE during caching—a speedup of 2x to 4x is a reasonable estimate.
|
I don't think this would be where it is doing the caching though. Converting SDXL VAE to fp16 also can cause NaN issues so we probably wouldn't want to convert it to fp16 regardless. The memory format might be what we can try from this as it might improve the performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
With some help from DeepSeek, this PR aims to improve latent caching speed.
Key Changes:
Mixed Precision Caching: VAE encoding now uses FP16 (or BF16) during latent caching for faster computation and reduced memory use.
Channels-Last VAE: VAE is temporarily switched to channels_last memory format during caching to improve GPU performance.
--vae_batch_size Utilization: This leverages the existing --vae_batch_size option; users should increase it for further speedups.
Benefits:
Significantly Faster Latent Caching: Reduces preprocessing time.
Improved GPU Efficiency: Optimizes VAE encoding on GPUs.
Impact: Faster training setup due to quicker latent caching.
This is much more concise and directly highlights the essential changes and their impact. Let me know if you would like it even shorter or with any other adjustments!
Based on the optimizations implemented—mixed precision and channels-last format for the VAE during caching—a speedup of 2x to 4x is a reasonable estimate.