xml value tag is multiple, so return it as array of values (#34)

Co-authored-by: Ondřej Sochůrek <sochurek@evosoft.cz>
laravie · Nov 17, 2022 · b47d617 · b47d617
1 parent ac12ff5
commit b47d617
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/Xml/Document.php b/src/Xml/Document.php
@@ -73,7 +73,7 @@ protected function getValue($content, ?string $use, ?string $default = null)
     }
 
     /**
-     * Cast value to string only when it is an instance of SimpleXMLElement.
+     * Cast value to string|array only when it is an instance of SimpleXMLElement.
      *
      * @param  mixed  $value
      *
@@ -82,7 +82,11 @@ protected function getValue($content, ?string $use, ?string $default = null)
     protected function castValue($value)
     {
         if ($value instanceof SimpleXMLElement) {
-            $value = (string) $value;
+            if ($value->count() > 1) {
+                $value = (array) $value;
+            } else {
+                $value = (string) $value;
+            }
         }
 
         return $value;

diff --git a/tests/Xml/DocumentTest.php b/tests/Xml/DocumentTest.php
@@ -750,7 +750,10 @@ public function testParseValueCollectionMultiLevelsPartTwo()
                                         [
                                             'DataAreaCode' => 'AREA2_CODE',
                                             'Detail'       => [
-                                                'DynPar' => 'T0019:2,R0109:test2,R0108:,R0107:,T0025:X',
+                                                'DynPar' => [
+                                                    'T0019:2,R0109:test2,R0108:,R0107:,T0025:X',
+                                                    'T0019:3,R0109:test3,R0108:,R0107:,T0025:Y',
+                                                ],
                                             ],
                                         ],
                                     ],
@@ -796,6 +799,7 @@ public function testParseValueCollectionMultiLevelsPartTwo()
 						<DataAreaCode>AREA2_CODE</DataAreaCode>
 						<Detail>
 							<DynPar>T0019:2,R0109:test2,R0108:,R0107:,T0025:X</DynPar>
+							<DynPar>T0019:3,R0109:test3,R0108:,R0107:,T0025:Y</DynPar>
 						</Detail>
 					</Localization>
 				</Error>