Changes for moving state build to FCM

linkedin · Nov 28, 2024 · 80d1bce · 80d1bce
1 parent e9b1d5a
commit 80d1bce
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 14 deletions.
diff --git a/ambry-api/src/main/java/com/github/ambry/config/ClusterMapConfig.java b/ambry-api/src/main/java/com/github/ambry/config/ClusterMapConfig.java
@@ -372,8 +372,6 @@ public class ClusterMapConfig {
   @Default("false")
   public final boolean clusterMapIgnoreDownwardStateTransition;
 
-  public static final String ENABLE_FILE_COPY_FOR_BOOTSTRAP = "clustermap.enable.file.copy.for.bootstrap";
-
   public ClusterMapConfig(VerifiableProperties verifiableProperties) {
     clusterMapFixedTimeoutDatanodeErrorThreshold =
         verifiableProperties.getIntInRange("clustermap.fixedtimeout.datanode.error.threshold", 3, 1, 100);

diff --git a/ambry-clustermap/src/main/java/com/github/ambry/clustermap/HelixParticipant.java b/ambry-clustermap/src/main/java/com/github/ambry/clustermap/HelixParticipant.java
@@ -65,8 +65,6 @@
  */
 public class HelixParticipant implements ClusterParticipant, PartitionStateChangeListener {
   public static final String DISK_KEY = "DISK";
-
-  public static final boolean ENABLE_FILE_COPY = false;
   final HelixParticipantMetrics participantMetrics;
   private final HelixClusterManager clusterManager;
   private final String clusterName;
@@ -876,15 +874,10 @@ public void onPartitionBecomeBootstrapFromOffline(String partitionName) {
         storageManagerListener.onPartitionBecomeBootstrapFromOffline(partitionName);
       }
 
-      if (ENABLE_FILE_COPY) {
-        // TODO: Filecopy Invocation
-        // TODO: Statebuild Invocation: storageManagerListener.buildStateForFileCopy. Functional signature
-        //        1. TODO: Start the store
-        //        2. TODO: Enable compaction for the new started store
-
-        // StateBuilding
-        storageManagerListener.buildStateForFileCopy(partitionName);
-      }
+      // TODO: Filecopy Invocation
+      // TODO: Statebuild Invocation: storageManagerListener.buildStateForFileCopy. Functional signature
+      //        1. TODO: Start the store
+      //        2. TODO: Enable compaction for the new started store
 
       // 2. take actions in replication manager (add new replica if necessary)
       PartitionStateChangeListener replicationManagerListener =

diff --git a/ambry-file-transfer/src/main/java/com/github/ambry/FileCopyManager.java b/ambry-file-transfer/src/main/java/com/github/ambry/FileCopyManager.java
@@ -41,7 +41,8 @@ class PartitionStateChangeListenerImpl implements PartitionStateChangeListener {
 
     @Override
     public void onPartitionBecomeBootstrapFromOffline(String partitionName) {
-
+      // StateBuilding at the end of FCM's Offline->Bootstrap transition
+      storeManager.buildStateForFileCopy(partitionName);
     }
 
     @Override