node: optick: fix capture output with multiple outputs #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnez
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Hi, you have a duplicate adding in your commit message (before adding adding the state) (it would be great if GitHub would allow commenting on the commit message).
If you choose to fix that, it would be great if you could rebase on top of origin/master to fix the codespell issue that was fixed with #49.
But I do not insist on that. The logic looks valid to me and from my point of view this can be merged as-is,
The raw events are lists with timestamps and state per input. The output contains the state of all the outputs for each timstamp. The lists must be merged and sorted before adding the state of the other inputs for each timestamp. Otherwise an old state value is used and the output is incorrect. Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
michaelolbrich
force-pushed
the
optick-capture
branch
from
99abf60 to
0bea34d
Compare
|
Commit message fixed and rebased. |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The raw events are lists with timestamps and state per input. The output contains the state of all the outputs for each timstamp.
The lists must be merged and sorted before adding adding the state of the other inputs for each timestamp. Otherwise an old state value is used and the output is incorrect.