Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply review results from a meta-lxatac derived BSP #122

Merged
merged 10 commits into from
Mar 28, 2024

Conversation

hnez
Copy link
Member

@hnez hnez commented Mar 19, 2024

I've based a (currently non-public) BSP on meta-lxatac, which was in turn reviewed by @Bastian-Krause, who provided great input on how to improve said BSP.

Since the BSP is based on meta-lxatac, some of these review results also apply here, so I am going through them and applying them here as well.

TODO before merging:

  • Go through the complete review and apply the findings.
  • Decide how to provide proper attribution to @Bastian-Krause, by e.g. making him the git author or adding a note to the commits.
  • Test the changes to make sure they do not accidentally break something.

Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
@hnez hnez requested a review from Bastian-Krause March 19, 2024 08:38
@hnez hnez self-assigned this Mar 19, 2024
hnez added 8 commits March 19, 2024 09:41
Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
…only

Could later be overridden via a machine override, if necessary.

Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
@hnez hnez force-pushed the trickle-down-fixes branch from 3067bb2 to 20f1a12 Compare March 19, 2024 08:41
Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
@hnez hnez force-pushed the trickle-down-fixes branch from 20f1a12 to 34a18ff Compare March 28, 2024 10:22
@hnez hnez marked this pull request as ready for review March 28, 2024 10:23
@hnez hnez merged commit 97d5ca8 into linux-automation:nanbield Mar 28, 2024
2 checks passed
@hnez hnez deleted the trickle-down-fixes branch March 28, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants