Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: build: throw away the previous build artifacts #159

Closed
wants to merge 1 commit into from

Conversation

hnez
Copy link
Member

@hnez hnez commented Jul 31, 2024

Note

I am not convinced that this is a necessary or useful change.
I would personally prefer keeping the CI job as is.
This PR was mainly created to check what kind of impact such a change would have on the build time.

Keeping only the sstate an downloads between runs makes the result a bit more reproducible at the cost of having to do a bit more work per-run.

Keeping only the sstate an downloads between runs makes the result a bit
more reproducible at the cost of having to do a bit more work per-run.

Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
@jluebbe
Copy link
Member

jluebbe commented Jul 31, 2024

@hnez
Copy link
Member Author

hnez commented Jul 31, 2024

Not quite, but close. The 6:33 job actually built some things, while the 8:23 did not.

I re-ran the first job to have a fair comparison: https://github.com/linux-automation/meta-lxatac/actions/runs/10176907868

Now it's 1:46 vs. 8:23. Both are acceptable CI build times in my opinion.

I would nevertheless prefer to keep the build job as-is right now to gather some experience and to find out if it causes issues in practice. I am more than willing enough to troubleshoot those if they were to arise.

@hnez
Copy link
Member Author

hnez commented Jul 31, 2024

I will close this PR until our builds fail catastrophically and I get tired of fixing them.
Then we can re-open it.

@hnez hnez closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants