Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add oelint-adv based linter for our own recipes #224

Open
wants to merge 32 commits into
base: scarthgap
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
65cc41a
meta-lxatac-software: lxatac-profile: set LG_COORDINATOR not LG_CROSSBAR
hnez Dec 20, 2024
e1bb04a
meta-lxatac-software: container-control: set ...:${PN} not ..._${PN}
hnez Dec 20, 2024
9253ae2
oelint: add linter configuration
hnez Dec 20, 2024
91966cd
CI: add oelint-adv linter rule
hnez Dec 9, 2024
f1e9726
meta-lxatac-{bsp,software}: fix indentation in recipes
hnez Dec 20, 2024
9627468
meta-lxatac-{bsp,software}: fix whitespace in var assign, add and append
hnez Dec 20, 2024
8fb7e89
meta-lxatac-bsp: tf-a-stm32mp_2.9: remove superfluous empty line
hnez Dec 9, 2024
621b4bf
meta-lxatac-{bsp,software}: Sort DEPENDS and RDEPENDS alphabetically
hnez Dec 20, 2024
c3fc800
meta-lxatac-{bsp,software}: Provide better/shorter/any at all SUMMARYs
hnez Dec 20, 2024
696e100
meta-lxatac-{bsp,software}: use SRC_URI:append instead if +=
hnez Dec 20, 2024
be19a66
meta-lxatac-{bsp,software}: Do not override FILES and append instead
hnez Dec 20, 2024
b878102
meta-lxatac-bsp: lxatac-net-switch-hacks: Do not add sysconfdir to FILES
hnez Dec 20, 2024
e29005d
meta-lxatac-bsp: arm-trusted-firmware-a: Do not override variables in…
hnez Dec 20, 2024
4dad2f0
meta-lxatac-bsp: barebox: add oelint exception for require image-uefi…
hnez Dec 20, 2024
ae44f64
meta-lxatac-bsp: barebox: use DEPENDS:append instead of assign in .inc
hnez Dec 20, 2024
d34f86f
meta-lxatac-bsp: barebox: add documentation for the do_copy_fw task
hnez Dec 20, 2024
691c4bc
meta-lxatac-bsp: linux-lxatac: add documentation for the do_copy_fw task
hnez Dec 20, 2024
f4aaf20
meta-lxatac-software: tacd-webinterface: add docs for the do_copy_fw …
hnez Dec 20, 2024
94ce07a
meta-lxatac-bsp: fiptool-native: use inherit_defer native
hnez Dec 20, 2024
83e89c9
meta-lxatac-software: panel-mipi-dbi-native: use inherit_defer native
hnez Dec 20, 2024
c7a07b6
meta-lxatac-bsp: lxatac-net-switch-hacks: depend on util-linux-chrt only
hnez Dec 20, 2024
0bc4ab5
meta-lxatac-bsp: linux-lxatac: disable oelint for false positive
hnez Dec 20, 2024
78e03bb
meta-lxatac-software: github-act-runner: ignore do_compile[network] o…
hnez Dec 20, 2024
3517acd
meta-lxatac-software: gitlab-runner: ignore do_compile[network] oelint
hnez Dec 20, 2024
cf26f81
meta-lxatac-software: classes: panel-mipi-dbi rename to panel_mipi_dbi
hnez Dec 20, 2024
c2caf27
meta-lxatac-software: rkdeveloptool: add upstream status to Makefile …
hnez Dec 20, 2024
f62259d
meta-lxatac-software: bottom: remove require of non-existant files
hnez Dec 20, 2024
357f3b9
meta-lxatac-software: tacd: use require for existing files only
hnez Dec 20, 2024
2077954
meta-lxatac-software: ripgrep: remove require of non-existant files
hnez Dec 20, 2024
c30ee39
meta-lxatac-software: tac-gadget: Do not add bindir to FILES
hnez Dec 20, 2024
f0dcecc
meta-lxatac-{bsp, software}: order variables according to oelint.var.…
hnez Dec 20, 2024
c618afa
meta-lxatac-software: lxatac-core-image-base: add oelint exception
hnez Jan 2, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
# umpf-hashinfo: e9c0f04902a5616a0af04fc9490edd9f1273ab7c
# umpf-topic-range: d3e71ead6ea5bc3555ac90a446efec84ef6c6122..927790a02af8f782da3c11fc599017767d175de8
SRC_URI += "\
file://patches/0001-fdts-lxa-tac-add-Linux-Automation-GmbH-TAC.patch \
"
file://patches/0001-fdts-lxa-tac-add-Linux-Automation-GmbH-TAC.patch \
"
# umpf-release: 2.9/customers/lxa/tac/20240130-2
# umpf-topic-range: 927790a02af8f782da3c11fc599017767d175de8..2c9a028d8673d1b3f8ce99e58ec61c4554b60fda
SRC_URI += "\
file://patches/0101-Release-2.9-customers-lxa-tac-20240130-2.patch \
"
file://patches/0101-Release-2.9-customers-lxa-tac-20240130-2.patch \
"
# umpf-end
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ EXTRA_OEMAKE = " \
ARCH=sandbox \
CROSS_COMPILE=${TARGET_PREFIX} -C ${S} O=${B} \
CROSS_PKG_CONFIG=pkg-config \
"
"

do_compile:class-target () {
export userccflags="${TARGET_CC_ARCH}${TOOLCHAIN_OPTIONS}"
Expand Down
12 changes: 6 additions & 6 deletions meta-lxatac-bsp/recipes-bsp/barebox/barebox_2024.10.0.bb
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ COMPATIBLE_MACHINE = "lxatac"
BAREBOX_DTBS_TO_DEPLOY = "arch/arm/dts/*.dtb"

do_deploy:append () {
for DTB in ${BAREBOX_DTBS_TO_DEPLOY}; do
if [ -e ${DTB} ]; then
BAREBOX_DTB_BASENAME=barebox-$(basename ${DTB} .dtb)${BAREBOX_IMAGE_SUFFIX}
install -m 644 -T ${DTB} ${DEPLOYDIR}/${BAREBOX_DTB_BASENAME}.dtb
fi
done
for DTB in ${BAREBOX_DTBS_TO_DEPLOY}; do
if [ -e ${DTB} ]; then
BAREBOX_DTB_BASENAME=barebox-$(basename ${DTB} .dtb)${BAREBOX_IMAGE_SUFFIX}
install -m 644 -T ${DTB} ${DEPLOYDIR}/${BAREBOX_DTB_BASENAME}.dtb
fi
done
}

DEPENDS:append = " panel-shineworld-lh133k"
Expand Down
36 changes: 18 additions & 18 deletions meta-lxatac-bsp/recipes-bsp/barebox/files/patches/series.inc
Original file line number Diff line number Diff line change
Expand Up @@ -6,31 +6,31 @@
# umpf-hashinfo: 6d130e9537b785ad42b8bfb6d0d9c91fd70a3eea
# umpf-topic-range: 1f31cde526d4e251da6464cac42ee2252643b972..3b1c5b6c26759c488ca8aa83e9145972d229eea7
SRC_URI += "\
file://patches/0001-scripts-implement-slurp-a-read_file-with-fd-as-argum.patch \
file://patches/0002-of_path-support-phandles-in-of_find_path.patch \
file://patches/0003-Makefile-add-common-boards-include-to-include-search.patch \
file://patches/0004-net-add-ethaddr-sequence-handling.patch \
file://patches/0005-common-add-optional-systemd.hostname-generation.patch \
file://patches/0006-net-factor-out-eth_of_get_fixup_node.patch \
file://patches/0007-net-export-list-of-registered-ethernet-addresses.patch \
file://patches/0008-net-implement-ethaddr_string_cmp.patch \
file://patches/0009-common-add-barebox-TLV-support.patch \
file://patches/0010-commands-add-TLV-debugging-command.patch \
file://patches/0011-scripts-add-bareboxtlv-host-target-tool.patch \
"
file://patches/0001-scripts-implement-slurp-a-read_file-with-fd-as-argum.patch \
file://patches/0002-of_path-support-phandles-in-of_find_path.patch \
file://patches/0003-Makefile-add-common-boards-include-to-include-search.patch \
file://patches/0004-net-add-ethaddr-sequence-handling.patch \
file://patches/0005-common-add-optional-systemd.hostname-generation.patch \
file://patches/0006-net-factor-out-eth_of_get_fixup_node.patch \
file://patches/0007-net-export-list-of-registered-ethernet-addresses.patch \
file://patches/0008-net-implement-ethaddr_string_cmp.patch \
file://patches/0009-common-add-barebox-TLV-support.patch \
file://patches/0010-commands-add-TLV-debugging-command.patch \
file://patches/0011-scripts-add-bareboxtlv-host-target-tool.patch \
"
# umpf-topic: v2024.10.0/customers/lxa/tac
# umpf-hashinfo: 1413c76bc3233a8732a51c3010d6a8433e2b7e3a
# umpf-topic-range: 3b1c5b6c26759c488ca8aa83e9145972d229eea7..df227f29447718518a7bb92954fc4f74aa58d77f
SRC_URI += "\
file://patches/0101-boards-add-decoder-for-LXA-TLV-v1-format.patch \
file://patches/0102-ARM-dts-stm32-lxa-tac-fix-gen-1-2-boards-and-add-gen.patch \
file://patches/0103-ARM-stm32mp-add-Linux-Automation-TAC-board.patch \
"
file://patches/0101-boards-add-decoder-for-LXA-TLV-v1-format.patch \
file://patches/0102-ARM-dts-stm32-lxa-tac-fix-gen-1-2-boards-and-add-gen.patch \
file://patches/0103-ARM-stm32mp-add-Linux-Automation-TAC-board.patch \
"
# umpf-release: 2024.10.0/customers/lxa/tac/20241121-2
# umpf-topic-range: df227f29447718518a7bb92954fc4f74aa58d77f..be16d68f8fa1f5197557d48c1f0b9f50cc342895
SRC_URI += "\
file://patches/0201-Release-2024.10.0-customers-lxa-tac-20241121-2.patch \
"
file://patches/0201-Release-2024.10.0-customers-lxa-tac-20241121-2.patch \
"
UMPF_BASE = "2024.10.0"
UMPF_VERSION = "20241121-2"
UMPF_PV = "${UMPF_BASE}-${UMPF_VERSION}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ SRC_URI += " \
file://01-disable_switch_ipv6.conf \
file://50-g-usb.link \
file://52-switch.link \
"
"

N = "${libdir}/NetworkManager/system-connections"

Expand Down
4 changes: 2 additions & 2 deletions meta-lxatac-bsp/recipes-core/lxatac-repart/lxatac-repart.bb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ SRC_URI = " \
file://repart.d \
file://ordering.conf \
file://repart-before-tmpfiles.conf \
"
"

S = "${WORKDIR}"

Expand All @@ -31,5 +31,5 @@ FILES:${PN} = " \
/system-update \
${libdir}/repart.d \
${libdir}/systemd/system/systemd-repart.service.d \
"
"

22 changes: 11 additions & 11 deletions meta-lxatac-bsp/recipes-kernel/linux/files/patches/series.inc
Original file line number Diff line number Diff line change
Expand Up @@ -6,24 +6,24 @@
# umpf-hashinfo: d6ed6f191343a77bfe41d7436b51dffe8bcac441
# umpf-topic-range: adc218676eef25575469234709c2d87185ca223a..8c8650a9514ce98c07b891b95f09da0e05d5913f
SRC_URI += "\
file://patches/0001-ARM-Don-t-mention-the-full-path-of-the-source-direct.patch \
"
file://patches/0001-ARM-Don-t-mention-the-full-path-of-the-source-direct.patch \
"
# umpf-topic: v6.12/customers/lxa/lxatac
# umpf-hashinfo: c7dc846896e7c2880071cd9fb4ae9b94d8d9e38e
# umpf-topic-range: 8c8650a9514ce98c07b891b95f09da0e05d5913f..c1a85acf9596faad5cd2df730cdbb2eb937c8418
SRC_URI += "\
file://patches/0101-ARM-dts-stm32-lxa-tac-disable-the-real-time-clock.patch \
file://patches/0102-ARM-dts-stm32-lxa-tac-extend-the-alias-table.patch \
file://patches/0103-ARM-dts-stm32-lxa-tac-adjust-USB-gadget-fifo-sizes-f.patch \
file://patches/0104-dt-bindings-arm-stm32-add-compatible-strings-for-Lin.patch \
file://patches/0105-ARM-dts-stm32-lxa-tac-move-adc-and-gpio-e-g-to-gen-1.patch \
file://patches/0106-ARM-dts-stm32-lxa-tac-Add-support-for-generation-3-d.patch \
"
file://patches/0101-ARM-dts-stm32-lxa-tac-disable-the-real-time-clock.patch \
file://patches/0102-ARM-dts-stm32-lxa-tac-extend-the-alias-table.patch \
file://patches/0103-ARM-dts-stm32-lxa-tac-adjust-USB-gadget-fifo-sizes-f.patch \
file://patches/0104-dt-bindings-arm-stm32-add-compatible-strings-for-Lin.patch \
file://patches/0105-ARM-dts-stm32-lxa-tac-move-adc-and-gpio-e-g-to-gen-1.patch \
file://patches/0106-ARM-dts-stm32-lxa-tac-Add-support-for-generation-3-d.patch \
"
# umpf-release: 6.12/customers/lxa/lxatac/20241121-1
# umpf-topic-range: c1a85acf9596faad5cd2df730cdbb2eb937c8418..177206858679e0e2f5e0ef4bf5dfe093120c3cc0
SRC_URI += "\
file://patches/0201-Release-6.12-customers-lxa-lxatac-20241121-1.patch \
"
file://patches/0201-Release-6.12-customers-lxa-lxatac-20241121-1.patch \
"
UMPF_BASE = "6.12"
UMPF_VERSION = "20241121-1"
UMPF_PV = "${UMPF_BASE}-${UMPF_VERSION}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ S = "${WORKDIR}"
RDEPENDS:${PN} = "bash"

do_install () {
install -d ${D}${sysconfdir}/profile.d/
install -m 0755 ${S}/01-labgrid.sh ${D}${sysconfdir}/profile.d/
install -d ${D}${sysconfdir}/profile.d/
install -m 0755 ${S}/01-labgrid.sh ${D}${sysconfdir}/profile.d/
}

FILES:${PN} = "${sysconfdir}/profile.d/01-labgrid.sh"
6 changes: 3 additions & 3 deletions meta-lxatac-software/recipes-rust/ripgrep/ripgrep_14.1.1.bb
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,14 @@ SRC_URI[windows_x86_64_gnu-0.52.6.sha256sum] = "147a5c80aabfbf0c7d901cb5895d1de3
SRC_URI[windows_x86_64_gnullvm-0.52.6.sha256sum] = "24d5b23dc417412679681396f2b49f3de8c1473deb516bd34410872eff51ed0d"
SRC_URI[windows_x86_64_msvc-0.52.6.sha256sum] = "589f6da84c646204747d1270a2a5661ea66ed1cced2631d546fdfb155959f9ec"

LIC_FILES_CHKSUM = " \
LIC_FILES_CHKSUM = "\
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This better fits the next commit.

file://LICENSE-MIT;md5=8d0d0aa488af0ab9aafa3b85a7fc8e12 \
file://UNLICENSE;md5=7246f848faa4e9c9fc0ea91122d6e680 \
"

SUMMARY = "ripgrep is a line-oriented search tool that recursively searches your current \
directory for a regex pattern while respecting your gitignore rules. ripgrep \
has first class support on Windows, macOS and Linux."
directory for a regex pattern while respecting your gitignore rules. ripgrep \
has first class support on Windows, macOS and Linux."
HOMEPAGE = "https://github.com/BurntSushi/ripgrep"
LICENSE = "Unlicense | MIT"

Expand Down
2 changes: 1 addition & 1 deletion meta-lxatac-software/recipes-rust/tacd/tacd.inc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ SRC_URI += " \
file://de.pengutronix.tacd.conf \
file://01_stable.yaml \
file://05_testing.yaml \
"
"

inherit pkgconfig
inherit systemd
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ SUMMARY = "The LXA TAC System Daemon - Web Interface"
SRC_URI = " \
git://github.com/linux-automation/tacd.git;protocol=https;branch=main \
npmsw://${THISDIR}/${BPN}/npm-shrinkwrap.json \
"
"
LICENSE = "GPL-2.0-or-later"
LIC_FILES_CHKSUM = " \
file://../LICENSE;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
Expand Down