Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta-lxatac-bsp: rauc: add patch to fix RAUC info / update notifications #98

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

hnez
Copy link
Member

@hnez hnez commented Jan 19, 2024

Currently the update notifications on the LXA TAC LCD and web interface do not work because the tacd can not get informations about the RAUC bundle on the update server via RAUC's DBus API.

This is because the process that RAUC spawns to handle the nbd bridge for http streaming crashes due to an unitialized pointer access.

This patch is taken from RAUC pull request rauc/rauc#1332 , which fixes the issue.


The behavior of g_variant_dict_lookup() has also recently been clarified
in the glib documentation:
https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3334
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add an Upstream-Status like:

Upstream-Status: Submitted [https://github.com/rauc/rauc/pull/1332]

Currently the update notifications on the LXA TAC LCD and web interface
do not work because the tacd can not get informations about the RAUC
bundle on the update server via RAUC's DBus API.

This is because the process that RAUC spawns to handle the nbd bridge
for http streaming crashes due to an unitialized pointer access.

This patch is taken from RAUC pull request 1332 [1], which fixes the issue.

[1]: rauc/rauc#1332

Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
@hnez
Copy link
Member Author

hnez commented Jan 19, 2024

You might want to add an Upstream-Status like:

Sounds good. Is this the correct place to put it:

https://github.com/linux-automation/meta-lxatac/compare/f24eb46b0ac2732da3b708d66c8e07abc87dc08e..8eb01d4382db1ac543823dfb7dba4141f429bc4e

?

@ejoerns
Copy link
Collaborator

ejoerns commented Jan 19, 2024

You might want to add an Upstream-Status like:

Sounds good. Is this the correct place to put it:

https://github.com/linux-automation/meta-lxatac/compare/f24eb46b0ac2732da3b708d66c8e07abc87dc08e..8eb01d4382db1ac543823dfb7dba4141f429bc4e

?

I do think so, yes. 👍

@hnez
Copy link
Member Author

hnez commented Jan 19, 2024

Cool! Then I think we should get this merged sooner than later to prevent users from gettting stuck on LXA TAC images without update notifications.

@hnez hnez merged commit 848036f into linux-automation:nanbield Jan 19, 2024
2 checks passed
@hnez hnez deleted the fix-rauc-info branch January 19, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants