ui: reduce idle brightness of the status led #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first hardware samples of LXA TACs with status LEDs showed them to be far to bright. Since then we have reduced the current through the "normal" (non-pwm) status LEDs by a factor of 33 in hardware. The brightness of the pwm LEDs was only reduced in hardware by a factor of 7.5. This allows us to still make them light up quite brightly if we want them to. In the idle state their brightness should however match the brightness of the other LEDs. Dim them in software by a factor of 33/7.5 = 4.4. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
jluebbe
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first hardware samples of LXA TACs with status LEDs showed them to be far to bright. Since then we have reduced the current through the "normal" (non-pwm) status LEDs by a factor of
33in hardware. The brightness of the pwm LEDs was only reduced in hardware by a factor of7.5. This allows us to still make them light up quite brightly if we want them to.In the idle state their brightness should however match the brightness of the other LEDs.
Dim them in software by a factor of
33/7.5 = 4.4.