rauc: perform retries with exponential backoff #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarlK90
previously requested changes
Jan 19, 2024
hnez
force-pushed
the
rauc-bundle-polling-wait
branch
from
6f0a559 to
f820f42
Compare
hnez
changed the title
hnez
force-pushed
the
rauc-bundle-polling-wait
branch
from
f820f42 to
50d8b37
Compare
|
Hi @KarlK90, could you have a second look at this PR? |
Emantor
approved these changes
May 24, 2024
Emantor
requested changes
May 24, 2024
Emantor
approved these changes
May 24, 2024
The first poll for updates after a fresh boot usually fails, because the network is not yet up. This means an update notification will only appear once one polling interval passed since startup (which can be on the order of days). Retry the polling process with exponential backoff to both recover fast from short-term issues (like the network not being up yet) and also prevent the update server from being DDOSed from excessive retries. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
hnez
force-pushed
the
rauc-bundle-polling-wait
branch
from
50d8b37 to
9d0e394
Compare
hnez
dismissed
KarlK90’s stale review
I've replaced the hardcoded waiting with retries with exponential backoff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first poll for updates after a fresh boot usually fails, because the network is not yet up.
This means an update notification will only appear once one polling interval passed since startup (which can be on the order of days).
We could use a heuristic to decide once the network is up so we can start polling, but we are in no hurry and can just wait a bit before the first poll. "A bit" being two minutes in this case because it feels about right.Edit: the fixed delay was replaced by an exponential backoff that starts at 1min, then 2min, 4min, 8min, 16min, 32min and then the bundle is marked as currently unavailable.