rauc: use InstallBundle and InspectBundle instead of deprecated DBus methods #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emantor
approved these changes
Jun 25, 2024
This matches what we currently see in recent stable bundles. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
The InstallBundle method allows providing a dictionary of extra arguments, which makes it more flexible than Install. We do not use this flexibility yet, but with this update we can at least get rid of the stigma of using a deprecated API. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
The InspectBundle method allows providing a dictionary of extra arguments, which makes it more flexible than Info. We do not need this flexibility yet, but at least we no longer use a deprecated API. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so we no longer use deprecated RAUC DBus APIs.
The
Install->InstallBundlemigration is straight forward.The
Info->InspectBundlemigration is a bit trickier, since RAUC provides the results as nested dictionaries (and also arrays nested inside of that, but we do not currently need any info from those).This requires a fair bit of type conversions at runtime and the use of some rather funky generics from the
zvariantscrate.There are probably more elegant solutions to implement the
tacd-side of this, but for nowzvariant_walk_nested_dictsgives us something that works.