usb-sd-mux/FAST: Fix GPIO number-to-pin definition #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the mapping between the GPIO numbers (as written on the device) and the IOs of the I2C port-expander. This mismatch was present since support for the FAST was added in ab42135. It seems the swapping of the pins in the schematic has been overlooked (see linux-automation#83 for that particular part of the schematic) during tool development. Additionally early prototypes were missing the GPIO numbers in silkscreen - masking this problem. With this change we will break the pin assignment for all users of releases up to 24.01.1. Thus this must be added to the release notes. Signed-off-by: Chris Fiege <cfi@pengutronix.de>
hnez
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the mapping between the GPIO numbers (as written on the device) and the IOs of the I2C port-expander.
This mismatch was present since support for the FAST was added in ab42135.
It seems the swapping of the pins in the schematic has been overlooked (see #83 for that particular part of the schematic) during tool development. Additionally early prototypes were missing the GPIO numbers in silkscreen - masking this problem.
With this change we will break the pin assignment for all users of releases up to 24.01.1. Thus this must be added to the release notes.
I have tested these changes on a series production device. The pin definition is now correct.