Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid blocking on appearance dbus call #484

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BLumia
Copy link
Member

@BLumia BLumia commented Dec 6, 2024

避免 appearance 获取壁纸卡死

PMS: BUG-290147
Log:

避免 appearance 获取壁纸卡死

PMS: BUG-290147
Log:
@BLumia BLumia requested a review from tsic404 December 6, 2024 07:39
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在修改后的代码中,m_dbusAppearanceIface->setSync(false);m_dbusAppearanceIface->setUseCache(true); 的调用可能会影响DBus接口的同步性和缓存策略,需要确认这些设置是否符合预期的行为。
  • connect 语句中的 lambda 表达式捕获了 this 指针,这是一个常见的做法,但需要确保在 lambda 表达式中不会导致循环引用,从而影响对象的生命周期。

是否建议立即修改:

  • 是,需要确保修改后的代码不会引入新的问题,并且与预期的行为一致。同时,应该进行充分的测试来验证这些更改的正确性。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants