Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Webhooks] limit webhook patch to Liqo webhooks #2908

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

claudiolor
Copy link
Contributor

Description

This PR fixes a bug that caused Liqo to patch not only the Liqo webhooks but also the others in the cluster.

@github-actions github-actions bot added the fix Fixes a bug in the codebase. label Jan 22, 2025
@adamjensenbot
Copy link
Collaborator

Hi @claudiolor. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@claudiolor
Copy link
Contributor Author

/build

@fra98
Copy link
Member

fra98 commented Jan 23, 2025

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the clo/fix-weebhook-patch branch from 82f3ca0 to eee7ac2 Compare January 23, 2025 11:44
@aleoli
Copy link
Member

aleoli commented Jan 23, 2025

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jan 23, 2025
@adamjensenbot adamjensenbot merged commit 44f3886 into liqotech:master Jan 23, 2025
14 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug in the codebase. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants