deploy: use anchor to reuse common env variables. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the amount of information replicated in the compose file. Merging the reusable mappings must be done explicitly, using YAML merge feature [1], so it is not a limitation of the docker-compose we use in deploy. [1]: https://yaml.org/type/merge.html Fixes: 655c72f ("deploy: Add docker-compose to launch IOCs")
ericonr
approved these changes
Mar 8, 2024
Yes, but not with RFFE IOC itself. I ran a Debian container defining the variables the same way we do in the compose file (including the indirect definition of |
|
Feel free to merge, then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the amount of information replicated in the compose file. Merging the reusable mappings must be done explicitly, using YAML merge feature, so it is not a limitation of the docker-compose we use in deploy.
Fixes: 655c72f ("deploy: Add docker-compose to launch IOCs")