Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review CALC records + Optimize EVRE FPGA clock #46

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Review CALC records + Optimize EVRE FPGA clock #46

wants to merge 16 commits into from

Conversation

mmdonatti
Copy link
Collaborator

@mmdonatti mmdonatti commented Jun 17, 2024 •
edited
Loading

Main goals

  • Done! Optimize EVR and EVE to monitor EVG clock via a callback (CPP option in INP field)
  • Done! Review CALC records using setpoint and readback values to compose a single register value.
  • Done! Remove download protocol commands and associated records.
  • Done! Review ioc boot cmds.
  • Change protocol interrupts to get in statements
  • Do we need 0.01 second SCAN? Apparently is only an heuristic warning. See here

Changed/Created/Deleted Records

EVG

EVR

EVE

FOUT

See #45 to track history!

@mmdonatti
Copy link
Collaborator Author

mmdonatti commented Jul 5, 2024 •
edited
Loading

WARNING: current implementation breaks EVG init sequencer sncEVGSetup.stt. Solved!

@mmdonatti mmdonatti force-pushed the optim-calc branch 2 times, most recently from 7d17a63 to 025e434 Compare July 10, 2024 14:52
@mmdonatti
evg.db: include NMS to handle alarm severity
a4aa87b 
.INP field is being loaded by autosave

this commit will not change current behavior
@mmdonatti
ev{r,e}.db: remove not needed SCAN field
5e864d0 
process the record when a monitor occurs
@mmdonatti
{evg.db,timing.proto}: remove evg Control register CALCs
ae49668 
this calcs can lead to unexpected SP and RB behavior

remove records EVGEN and SEQEN
@mmdonatti
snc{EVRE,FOUT}Setup.stt: sequencer simplification to remove download
d31ae96
@mmdonatti
sncEVGSetup.stt: EVG sequencer simplification
076d7a5 
remove download and upload commands
@mmdonatti
{ev{e,g,r},fout}.db: remove download and update rb records
c3d1854
@mmdonatti
timing.proto: remove obsolete download and readback commands
597f00b
@mmdonatti
autosave_event.req: remove unused file
d678d9d 
event data stored by autosave_evg.req
@mmdonatti
st{EV{G,R,E},FOUT}.cmd: remove autosave manual trigger record
b58c4b3
@mmdonatti
{ev{g,r,e},fout}.db: remove Save-Cmd record
b44310e 
autosave uses a periodic monitor to save modified values
@mmdonatti
st{EV{G,R,E},FOUT}.cmd: remove .config dependency
85e6bb3 
asyn port name could be defined directly
@mmdonatti
timing.proto: remove obsolete AC Line register set protocol
7e15fe3
@mmdonatti
timing.proto: remove obsolete clock mux register set protocol
60a1840
@mmdonatti
{evg.db,timing.proto}: rf config register simplification
01c30ff
@mmdonatti
{ev{e,r}.db,timing.proto}: configuration register simplification
13abdaf
@mmdonatti
{ev{r,e,g},fout}.db: add ASG field to restricted records
167e78d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericonr ericonr Awaiting requested review from ericonr

@lsperissinotto lsperissinotto Awaiting requested review from lsperissinotto

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mmdonatti