Sourcery refactored master branch

[sourcery-ai]

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

[sourcery-ai]

Function BaseWorkerManager.are_all_workers_closed refactored with the following changes:

• Simplify boolean if expression (boolean-if-exp-identity)

[sourcery-ai]

Function BaseAsyncPoolExecutor.map refactored with the following changes:

• Swap if/else branches (swap-if-else-branches)
• Remove unnecessary else after guard condition (remove-unnecessary-else)

[sourcery-ai]

Function TestMap.test_map_return_order refactored with the following changes:

• Simplify generator expression (simplify-generator)

[sourcery-ai]

Function TestCancel.test_cancel_running refactored with the following changes:

• Replace if statement with if expression (assign-if-exp)

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.15%.

Quality metrics	Before	After	Change
Complexity	9.05 🙂	8.94 🙂	-0.11 👍
Method Length	42.17 ⭐	42.08 ⭐	-0.09 👍
Working memory	8.79 🙂	8.78 🙂	-0.01 👍
Quality	67.47% 🙂	67.62% 🙂	0.15% 👍

Other metrics	Before	After	Change
Lines	1182	1178	-4

Changed files	Quality Before	Quality After	Quality Change
aplex/executor.py	65.38% 🙂	65.47% 🙂	0.09% 👍
tests/integration/test_inte_executors.py	78.88% ⭐	78.96% ⭐	0.08% 👍
tests/integration/test_inte_futures.py	71.36% 🙂	72.91% 🙂	1.55% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
aplex/executor.py	BaseWorkerMixin.run	40 ⛔	427 ⛔	13 😞	17.76% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
aplex/executor.py	_HandlerThread._run	19 😞	127 😞	11 😞	46.45% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
aplex/executor.py	_HandlerThread._handle_worker_state	13 🙂	139 😞	12 😞	48.11% 😞	Try splitting into smaller methods. Extract out complex expressions
aplex/executor.py	BaseAsyncPoolExecutor.map	9 🙂	129 😞	13 😞	51.30% 🙂	Try splitting into smaller methods. Extract out complex expressions
aplex/executor.py	BaseWorkerMixin.run.handle_submit_queue	12 🙂	90 🙂	13 😞	53.69% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.