Use "US" for the location of all datasets #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-soltesz
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new dataset, the autoloader uses the bucket's location (e.g., "US" or "us-central1") as the dataset's location.
For the
archive-mlab-otibucket, the location is "us-central1" (single-region). But, the rest of the pipeline requires that the location of the underlying table be public-facing views be "US" (multi-region). This PR is changing the location of the datasets to always be "US".Related to m-lab/gcp-config#73.
Note: the existing datasets in mlab-oti will have to be deleted and the build re-run for them to be recreated with the new location.
This change is