Fix race condition when editing the "Check" field in the note (#967)

Co-authored-by: Acylation <532117255@qq.com>
marcusolsson · Nov 6, 2024 · 1131c57 · 1131c57
1 parent 02ff7cc
commit 1131c57
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 18 deletions.
diff --git a/src/ui/views/Board/BoardView.svelte b/src/ui/views/Board/BoardView.svelte
@@ -71,10 +71,10 @@
 
   const handleRecordCheck =
     (checkField: string): OnRecordCheck =>
-    (record) => {
+    (record, checked) => {
       api.updateRecord(
         updateRecordValues(record, {
-          [checkField]: !record.values[checkField],
+          [checkField]: checked,
         }),
         fields
       );

diff --git a/src/ui/views/Board/components/Board/CardList.svelte b/src/ui/views/Board/components/Board/CardList.svelte
@@ -37,8 +37,6 @@
   export let onDrop: OnRecordDrop;
   export let includeFields: DataField[];
   export let checkField: string | undefined;
-  const checked = (item: DataRecord): boolean =>
-    checkField ? (item.values[checkField] as boolean) : false;
   export let customHeader: DataField | undefined;
   export let boardEditing: boolean;
 
@@ -103,10 +101,10 @@
           {#if checkField}
             <span class="checkbox-wrapper">
               <Checkbox
-                checked={checked(item)}
-                on:check={() => {
-                  onRecordCheck(item);
-                }}
+                checked={checkField !== undefined
+                  ? !!item.values[checkField]
+                  : false}
+                on:check={({ detail: checked }) => onRecordCheck(item, checked)}
               />
             </span>
           {/if}

diff --git a/src/ui/views/Board/components/Board/types.ts b/src/ui/views/Board/components/Board/types.ts
@@ -9,7 +9,7 @@ export type Column = {
 };
 
 export type OnRecordClick = (record: DataRecord) => void;
-export type OnRecordCheck = (record: DataRecord) => void;
+export type OnRecordCheck = (record: DataRecord, checked: boolean) => void;
 export type OnRecordAdd = (column: string) => void;
 export type OnRecordDrop = (
   record: DataRecord,

diff --git a/src/ui/views/Calendar/CalendarView.svelte b/src/ui/views/Calendar/CalendarView.svelte
@@ -125,11 +125,11 @@
     }
   }
 
-  function handleRecordCheck(record: DataRecord) {
+  function handleRecordCheck(record: DataRecord, checked: boolean) {
     if (booleanField) {
       api.updateRecord(
         updateRecordValues(record, {
-          [booleanField.name]: !record.values[booleanField.name],
+          [booleanField.name]: checked,
         }),
         fields
       );
@@ -272,8 +272,8 @@
               onRecordChange={(record) => {
                 handleRecordChange(date, record);
               }}
-              onRecordCheck={(record) => {
-                handleRecordCheck(record);
+              onRecordCheck={(record, checked) => {
+                handleRecordCheck(record, checked);
               }}
               onRecordAdd={() => {
                 handleRecordAdd(date);

diff --git a/src/ui/views/Calendar/components/Calendar/Day.svelte b/src/ui/views/Calendar/components/Calendar/Day.svelte
@@ -35,7 +35,7 @@
   /**
    * onRecordCheck runs when the user Checks / Unchecks a calendar event.
    */
-  export let onRecordCheck: (record: DataRecord) => void;
+  export let onRecordCheck: (record: DataRecord, checked: boolean) => void;
 
   /**
    * onRecordChange runs when the user changes the checked state.

diff --git a/src/ui/views/Calendar/components/Calendar/EventList.svelte b/src/ui/views/Calendar/components/Calendar/EventList.svelte
@@ -17,7 +17,7 @@
   export let checkField: string | undefined;
 
   export let onRecordClick: (record: DataRecord) => void;
-  export let onRecordCheck: (record: DataRecord) => void;
+  export let onRecordCheck: (record: DataRecord, checked: boolean) => void;
   export let onRecordChange: (record: DataRecord) => void;
 
   function asOptionalBoolean(value: Optional<DataValue>): Optional<boolean> {
@@ -62,9 +62,7 @@
         checked={checkField !== undefined
           ? asOptionalBoolean(record.values[checkField])
           : undefined}
-        on:check={() => {
-          onRecordCheck(record);
-        }}
+        on:check={({ detail: checked }) => onRecordCheck(record, checked)}
       >
         <InternalLink
           linkText={record.id}