Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Search Feature #922

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

Signynt
Copy link
Contributor

@Signynt Signynt commented Jul 12, 2024

Addresses #556

Features

  • Allows selection of which property to search by (defaults to name)
  • Hooks into the preexisting filter backend
  • Case insensitive

Limitations

  • Dates get passed to the filter backend in a date format such as Sun Sep 18 2022 00:00:00 GMT+0200 (Central European Summer Time), which means that searching in date fields might not work as the user expects. This does have the unexpected benefit of being able to search for day of the week however.
    • This isn't a severe limitation, since simply searching for the year works as expected, and most more complex searches for dates should be done with filters

Demonstration

6RX0F2x.mp4

@Acylation
Copy link
Collaborator

Thanks for implementing this! Will put this off a little bit to see if it's possible to conduct search independent of specifying a field.

@Acylation Acylation added the kind/feature New feature request label Jul 18, 2024
@Acylation Acylation added this to the next milestone Jul 18, 2024
@welpdx
Copy link

welpdx commented Dec 30, 2024

Hey @Acylation, although I appreciate the attention to detail (and yes, ideally, search perhaps would be better as a prompt instead of a field), but in the absence of such a highly requested feature, I encourage the implementation of this working search PR, with the mindset that it is open to being scraped when a better search is implemented in the future.

@hozza
Copy link

hozza commented Jan 20, 2025

but in the absence of such a highly requested feature, I encourage the implementation of this working search PR.

I agree. Although a search across all fields would be ideal, a search feature within a column/field specified is so much better that nothing at all. It'll add a lot to the Projects experience.

+1 to implement this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants