Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date on new fields #998

Merged
merged 7 commits into from
Jan 27, 2025
Merged

Fix date on new fields #998

merged 7 commits into from
Jan 27, 2025

Conversation

mdbraber
Copy link
Contributor

It seems #948 did not entirely fix #936 - this seems to fix it @Acylation

@m-primo
Copy link

m-primo commented Jan 26, 2025

This fixed it. Thank you.

I made a video before and after:

Before:

_before.mp4

After:

_after.mp4

@Acylation
Copy link
Collaborator

Acylation commented Jan 26, 2025

Thanks for pointing this out. Don't worry about the check failure, I'm gonna take it over.

I'm doing heavy refactor towards date/time processing (see #974), during when I also noticed this bug and would possibly solve it in another way.

@Acylation Acylation merged commit 5148806 into marcusolsson:main Jan 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempting to edit a date field with a cleared date results in invalid date error
3 participants