fireInput will unset empty array.

matrix-lab · Jun 3, 2020 · 11ef4d4 · 11ef4d4
1 parent 18a9949
commit 11ef4d4
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 0 deletions.
diff --git a/src/ConditionsGeneratorTrait.php b/src/ConditionsGeneratorTrait.php
@@ -351,6 +351,7 @@ public function getInputArgs($key = null, $default = null)
     protected function isVaildInput($requestKey)
     {
         return Arr::has($this->inputArgs, $requestKey)
+            && Arr::get($this->inputArgs, $requestKey) !== []
             && Arr::get($this->inputArgs, $requestKey) !== null
             && Arr::get($this->inputArgs, $requestKey) !== '';
     }

diff --git a/tests/Unit/ConditionGeneratorTrait/HandlePaginate.php b/tests/Unit/ConditionGeneratorTrait/HandlePaginate.php
@@ -36,4 +36,17 @@ public function test_order()
             'id' => 'asc',
         ], Arr::get($conditions, 'order'));
     }
+
+    public function test_fireInput()
+    {
+        $fakeRequest = new FakeRequest();
+
+        $conditions = $fakeRequest->getConditions([
+            'empty_array_field' => []
+        ]);
+
+        $this->assertEquals([
+            'id' => 'asc',
+        ], Arr::get($conditions, 'order'));
+    }
 }
diff --git a/tests/Utils/FakeRequest.php b/tests/Utils/FakeRequest.php
@@ -8,6 +8,15 @@ class FakeRequest
 {
     use ConditionsGeneratorTrait;
 
+    protected function wheres()
+    {
+        return [
+            'empty_array_field' => $this->fireInput('empty_array_field', function($value) {
+                return $value.'%';
+            }),
+        ];
+    }
+
     protected function order()
     {
         return '+id';