Saulparedes/validate node name #298
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redent0r
commented
Jan 21, 2025
| @@ -53,7 +53,7 @@ spec: | |||
| - /bin/sh | |||
| args: | |||
| - "-c" | |||
| - while true; do echo $(ISTIO_META_CLUSTER_ID); sleep 10; done | |||
| - while true; do echo $(ISTIO_META_CLUSTER_ID); echo $(ISTIO_META_NODE_NAME); sleep 10; done | |||
There was a problem hiding this comment.
updated test case to show variables referencing node name in command line now get validated
Validate node name using upstream regexp https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/util/validation/validation.go#L177 https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-subdomain-names Signed-off-by: Saul Paredes <saulparedes@microsoft.com>
Redent0r
force-pushed
the
saulparedes/validate_node_name
branch
from
45eb35d to
3eeb1d2
Compare
Update samples Signed-off-by: Saul Paredes <saulparedes@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
upstream/missinglabel (orupstream/not-needed) has been set on the PR.Summary
genpolicy: validate node name
Validate node name using upstream regexp
https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/util/validation/validation.go#L177
https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-subdomain-names
Test Methodology
https://dev.azure.com/mariner-org/mariner/_build/results?buildId=716039&view=results