Added test plan for TypeSpec extension #5552
Open
+734
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaohua899
requested review from
RodgeFu,
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
microsoft-github-policy-service
bot
added
the
ide
xiaohua899
force-pushed
the
patch-1
branch
2 times, most recently
from
deb90af to
f01671f
Compare
Create image Add files via upload Update create-typespec-project-test-plan.md Create generate-client-code-from-typespec-test-plan.md Add files via upload Update generate-client-code-from-typespec-test-plan.md Create generate-openapi3-from-typespec-test-plan.md Add files via upload Update generate-openapi3-from-typespec-test-plan.md Update generate-openapi3-from-typespec-test-plan.md Create generate-server-stub-from-typespec-test-plan.md Add files via upload Update generate-server-stub-from-typespec-test-plan.md Add files via upload Create import-typespec-from-openapi3-test-plan.md
Update generate-server-stub-from-typespec-test-plan.md Update create-typespec-project-test-plan.md Create typespec-extension-basic-features-test-plan.md Add files via upload Update typespec-extension-basic-features-test-plan.md Update typespec-extension-basic-features-test-plan.md Add files via upload Update create-typespec-project-test-plan.md Update generate-client-code-from-typespec-test-plan.md Update generate-openapi3-from-typespec-test-plan.md Add files via upload Update generate-server-stub-from-typespec-test-plan.md Update import-typespec-from-openapi3-test-plan.md Update create-typespec-project-test-plan.md Update generate-client-code-from-typespec-test-plan.md Update generate-openapi3-from-typespec-test-plan.md Add files via upload Update generate-client-code-from-typespec-test-plan.md Add files via upload Update typespec-extension-basic-features-test-plan.md Update typespec-extension-basic-features-test-plan.md Update generate-client-code-from-typespec-test-plan.md Update generate-openapi3-from-typespec-test-plan.md Update create-typespec-project-test-plan.md Add files via upload Update generate-openapi3-from-typespec-test-plan.md
|
@microsoft-github-policy-service agree company="Microsoft" |
RodgeFu
reviewed
Jan 13, 2025
packages/typespec-vscode/test/manual/create-typespec-project-test-plan.md
Outdated
Show resolved
Hide resolved
RodgeFu
reviewed
Jan 13, 2025
packages/typespec-vscode/test/manual/create-typespec-project-test-plan.md
Outdated
Show resolved
Hide resolved
RodgeFu
reviewed
Jan 13, 2025
packages/typespec-vscode/test/manual/create-typespec-project-test-plan.md
Outdated
Show resolved
Hide resolved
RodgeFu
reviewed
Jan 13, 2025
packages/typespec-vscode/test/manual/create-typespec-project-test-plan.md
Outdated
Show resolved
Hide resolved
RodgeFu
reviewed
Jan 13, 2025
packages/typespec-vscode/test/manual/typespec-extension-basic-features-test-plan.md
Outdated
Show resolved
Hide resolved
RodgeFu
reviewed
Jan 13, 2025
packages/typespec-vscode/test/manual/import-typespec-from-openapi3-test-plan.md
Show resolved
Hide resolved
RodgeFu
reviewed
Jan 13, 2025
|
|
||
|  | ||
|
|
||
| ### Step 4: Select an Emitter Type. |
There was a problem hiding this comment.
the UI will be a little different after Compiler can provide template for default emitters. Will keep you updated.
RodgeFu
reviewed
Jan 13, 2025
packages/typespec-vscode/test/manual/generate-openapi3-from-typespec-test-plan.md
Outdated
Show resolved
Hide resolved
3 tasks
|
@RodgeFu We have updated by your comments, please re-review. |
RodgeFu
reviewed
Jan 21, 2025
|
|
||
|  | ||
|  | ||
|
|
There was a problem hiding this comment.
i saw there is a red line (error) in the screenshot. I think the newly create project should't have error. Could you help to double check what the error is?
There was a problem hiding this comment.
When creating the rest-api-spec repo project, the corresponding dependencies were not installed.
There was a problem hiding this comment.
@xiaohua899 as @RodgeFu said, I think tsp init shall generate package.json for users to install these necessary packages. Here is track issue: #5703.
RodgeFu
reviewed
Jan 21, 2025
|
|
||
| **Validate:** Whether to automatically pop up a completion prompt to list possible types, attributes, and operations. | ||
|
|
||
| - For `.tsp` file: |
There was a problem hiding this comment.
the screenshot shown is normal completion from vscode, not from typespec. please verify the completion from typespec model or operation.
RodgeFu
reviewed
Jan 21, 2025
|  | ||
|
|
||
| ### Step 3: Confirm the project folder where you will place the TypeSpec file converted from the specified OpenAPI3 specification. | ||
|
|
There was a problem hiding this comment.
this will only show when user right click on a file, if user right click on a folder, we won't prompt for selecting folder again.
RodgeFu
reviewed
Jan 21, 2025
|
|
||
|  | ||
|
|
||
| ### Step 5: Verify that `@typespec/http` and `@typespec/openapi3` are installed. |
There was a problem hiding this comment.
only openapi3 is needed and will be prompt if user didn't have it installed. Please check extension from PR #5451 for the latest user experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5444
Description
Added four test scenarios test plan to TypeSpec Extension:
@RodgeFu and @msyyc for notification.