Export and use utility functions from lib/utils

[steverice]

Export createStateSymbol from lib/utils, and export all of utils in @typespec/compiler so they can be used by other packages.

Additionally, replace duplicate definitions of utils functions in @typespec/compiler with imports from utils.

[timotheeguerin]

we actually wouldn't want to expose that outside of the compiler. This function generate a unique id for state symbols for the compiler only. For your own library you should use the already exposed sytem for defining state using createLibrary (Pass stateKeys and get the generated sysmbols form the created library object)

[steverice]

Thanks for pointing that out — agreed that we don't want to export createStateSymbol outside of @typespec/compiler.

I was adding it as an export so that we could use it in decorators.ts and deprecation.ts since compiler does not define its own "library" with createTypeSpecLibrary. Which of these alternatives do you think would be best?

• re-implement createStateSymbol inside of decorators.ts and deprecation.ts (the status quo ante)
• do define a "TypeSpec" library using createStateSymbol inside of compiler, and treat all of compiler's decorators as a part of that
• explicitly specify the exports from utils.ts in index.ts, so that we can export createStateSymbol for use within compiler but not export it outside of the module
• split up utils.ts into separate files, one of which contains internal-to-compiler utils and the other utility functions that should be exported

Either of the latter two solutions would also address whether we export useStateMap and useStateSet from compiler, which @bterlson suggested we probably don't want to do.

[timotheeguerin]

I think 3 or 4 sounds good but we do already expose those useStateMap and useStateSet as unsafe_ version for now if I remember correctly.

Is there anything else you wanted to export from there.

[timotheeguerin]

ah yeah its just a wrapper here. This file I believe is meant to be the internal utils of the compiler decorators. If we want something exposed somewhere else we should move it out.

I think we could consider also removing the unsafe_ prefix from useStateMap/Set and move them out of expermiental now as its been working quite well.

[steverice]

I think we could consider also removing the unsafe_ prefix from useStateMap/Set and move them out of expermiental now as its been working quite well.

This is proposed in #5699.