Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scaffolding option for csharp generator #5648

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Add scaffolding option for csharp generator #5648

wants to merge 16 commits into from

Conversation

markcowl
Copy link
Contributor

No description provided.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 17, 2025 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/http-server-csharp
Show changes

@typespec/http-server-csharp - fix ✏️

Add scaffolding option for csharp generator

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 17, 2025 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs 🛝 VSCode Extension

allenjzhang
allenjzhang approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@allenjzhang allenjzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. nit: Move mock to root project folder
  2. nit: use the TypeSpec project folder name for c# project name (maybe with _server suffix? instead of hardcode to aspnet.csproj.
  3. enable swagger UI integration with the path to generated OpenAPI spec

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 23, 2025
View reviewed changes
packages/http-server-csharp/src/cli/cli.ts
}

function execProcess(command: string): Promise<void> {
return waitForChildProcess((handlers) => exec(command, handlers));

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
absolute path
Loading
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArcturusZhang ArcturusZhang ArcturusZhang left review comments

@allenjzhang allenjzhang allenjzhang approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

@witemple-msft witemple-msft Awaiting requested review from witemple-msft witemple-msft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markcowl @azure-sdk @allenjzhang @ArcturusZhang