Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http-client-java, improve diagnostic #5702

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

weidongxu-microsoft
Copy link
Contributor

@weidongxu-microsoft weidongxu-microsoft commented Jan 22, 2025

link #5511

  1. bump tcgc to 0.50.2
  2. adopt part of the serializationOptions (not a full adoption due to bug [Bug]: tcgc, missing json for model within multipart Azure/typespec-azure#2118)
  3. refactor entry, now it is index.ts, which exposes the few types needed by compiler
  4. migrate to the standard diagnostic in typespec compiler
  5. some refactor on error/warning code and message, group some to same code, etc.
  6. add target to diagnostic, when we can find it

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:java Issue for the Java client emitter: @typespec/http-client-java label Jan 22, 2025
@azure-sdk
Copy link
Collaborator

No changes needing a change description found.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 22, 2025

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs 🛝 VSCode Extension

@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review January 23, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:java Issue for the Java client emitter: @typespec/http-client-java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants