Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: allow various font-sizes #238269

Draft
wants to merge 83 commits into
base: main
Choose a base branch
from
Draft

Draft: allow various font-sizes #238269

wants to merge 83 commits into from

Conversation

aiday-mar
Copy link
Contributor

@aiday-mar aiday-mar commented Jan 20, 2025

points to test:

  • when moving cursor from line that is normal height to line that is larger height, the cursor flickers, and moves to the end
  • verify that when selecting a word like export, all other instances in the modified lines are highlighted correctly
  • check that we are able to scroll the full expanded text, especially after reload
  • verify that cmd+hover makes the correct quiggle appear
  • verify sticky scroll rendering is correct
  • make sure that whitespace is correctly rendered
  • check that when moving with the cursor, the cursor and character positions are correctly aligned
  • check that multi-line selection is correctly rendered
  • check that multi-cursor is correctly rendered
  • check that font infos out of view are correctly rendered
  • check what happens when the font size is larger than the line height
  • verify that when adding new line from within modified line, the height is adapted correctly and synchronously with the line height. Currently the font size overflows, while the line height is shorter
    • The two are updated at different times. Hence instead I set a maximum size on the font so it is never larger than the line height, so font size does not exceed the line height.
  • verify that when word wrap is toggled on, and the window is resized down, the text is correctly wrapped
    • the line heights and font sizes are correctly adapted if needed (especially when editing)
    • the line breaks at the correct position
  • check can define several different font infos on line
  • check what happens when ranges for font infos intersect
  • test on checker.ts and that there is no performance lag
  • verify that last line font size is correct
  • verify parameter hints are correctly rendered
  • verify that IME input is the correct size
    • when accessibility turned on
    • when accessibility turned off
  • verify the font is correctly rendered on pasting
  • verify that when you remove all the text on that line, font info is correctly changed
  • check that screen reader works correctly with this PR
  • check what happens when the font size is smaller than the normal font size
  • check works when experimental edit context is enabled and disabled (specifically when enabled)
  • verify that the ghost text is still positioned in the middle when the font size is changed
  • make sure indent guides are correctly aligned
  • when pressing enter from line that is larger, the line height and font size are updated only a few seconds later (after decorations are updated)

check different overlays in view.ts

@aiday-mar aiday-mar self-assigned this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants