-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to move the Find dialog to the bottom of the document view #238345
base: main
Are you sure you want to change the base?
Add option to move the Find dialog to the bottom of the document view #238345
Conversation
Fixes microsoft#238337 Add option to move the Find dialog to the bottom of the document view. * Update `OverlayWidgetPositionPreference` enum in `src/vs/editor/browser/editorBrowser.ts` to include a new value `BOTTOM_CENTER`. * Modify `FindWidget` class in `src/vs/editor/contrib/find/browser/findWidget.ts` to support positioning the Find dialog at the bottom based on the new configuration option. * Adjust `_reveal` and `_hide` methods in `src/vs/editor/contrib/find/browser/findWidget.ts` to handle the new bottom position. * Add CSS styles in `src/vs/editor/contrib/find/browser/findWidget.css` to handle the new bottom position of the Find dialog. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/vscode/issues/238337?shareId=XXXX-XXXX-XXXX-XXXX).
@microsoft-github-policy-service agree |
* Update `OverlayWidgetPositionPreference` enum in `editorBrowser.ts` to include `BOTTOM_CENTER`, `LEFT_CENTER`, and `RIGHT_CENTER` * Modify `FindWidget` class in `findWidget.ts` to support positioning the Find dialog at the bottom, left, or right based on the new configuration option * Adjust `_reveal` and `_hide` methods in `findWidget.ts` to handle the new positions * Add CSS styles in `findWidget.css` to handle the new bottom, left, and right positions of the Find dialog
I am trying to figure out why one of the tests is failing. hopefully I should have a fix in a day or two. |
Fixes #238337
Add option to move the Find dialog to the bottom of the document view.
OverlayWidgetPositionPreference
enum insrc/vs/editor/browser/editorBrowser.ts
to include a new valueBOTTOM_CENTER
.FindWidget
class insrc/vs/editor/contrib/find/browser/findWidget.ts
to support positioning the Find dialog at the bottom based on the new configuration option._reveal
and_hide
methods insrc/vs/editor/contrib/find/browser/findWidget.ts
to handle the new bottom position.src/vs/editor/contrib/find/browser/findWidget.css
to handle the new bottom position of the Find dialog.For more details, open the Copilot Workspace session.