Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4]not enable rate limiter for restful v1 #39554

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from

Conversation

smellthemoon
Copy link
Contributor

@smellthemoon smellthemoon commented Jan 23, 2025

issue: #39556
pr: #39553
2.5: #39555

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smellthemoon
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smellthemoon smellthemoon changed the title fix: not enable rate limiter for restful v1 fix: [2.4]not enable rate limiter for restful v1 Jan 23, 2025
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 23, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Jan 23, 2025
Copy link
Contributor

mergify bot commented Jan 23, 2025

@smellthemoon Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Jan 23, 2025
Copy link
Contributor

mergify bot commented Jan 23, 2025

@smellthemoon Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Jan 23, 2025

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 80.38%. Comparing base (355dc82) to head (bfcc7d0).

Current head bfcc7d0 differs from pull request most recent head 73722a7

Please upload reports for the commit 73722a7 to get more accurate results.

Files with missing lines Patch % Lines
...nternal/distributed/proxy/httpserver/handler_v1.go 0.00% 0 Missing and 6 partials ⚠️
internal/distributed/proxy/httpserver/utils.go 40.00% 2 Missing and 1 partial ⚠️
internal/proxy/rate_limit_interceptor.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #39554      +/-   ##
==========================================
- Coverage   80.42%   80.38%   -0.04%     
==========================================
  Files        1080     1080              
  Lines      170108   170117       +9     
==========================================
- Hits       136808   136751      -57     
- Misses      28798    28846      +48     
- Partials     4502     4520      +18     
Files with missing lines Coverage Δ
internal/proxy/util.go 90.34% <100.00%> (+<0.01%) ⬆️
internal/distributed/proxy/httpserver/utils.go 85.84% <40.00%> (-0.19%) ⬇️
internal/proxy/rate_limit_interceptor.go 89.61% <40.00%> (-3.55%) ⬇️
...nternal/distributed/proxy/httpserver/handler_v1.go 86.71% <0.00%> (ø)

... and 42 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 23, 2025
internal/proxy/util.go Outdated Show resolved Hide resolved
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants