Node.js v22 Upgrade #934
Open
Node.js v22 Upgrade #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingenito
reviewed
Jan 24, 2025
.github/workflows/README.md
Outdated
| @@ -8,7 +8,7 @@ Accessing them can be done via the vars object. | |||
| | Variable | Description | Example value | | |||
| | -------------- | ------------------------------------------------------- | ------------- | | |||
| | DOTNET_VERSION | The version of dotnet to load with actions/setup-dotnet | 6.0.x | | |||
| | NODE_VERSION | The version of node.js to load with actions/setup-node | 18.x | | |||
| | NODE_VERSION | The version of node.js to load with actions/setup-node | 20.x | | |||
There was a problem hiding this comment.
It was meant to be 22. Good catch, let me fix that.
psmulovics
reviewed
Jan 24, 2025
| @@ -9,7 +9,7 @@ | |||
| "declaration": true, | |||
| "outDir": "output", | |||
| "lib": [ "es2022", "DOM" ], | |||
| "strict": true | |||
| "strict": false | |||
There was a problem hiding this comment.
Uhm, are we sure about this?
There was a problem hiding this comment.
we can't use 'with' in strict mode.
There was a problem hiding this comment.
ok, I did a double check. It looks like that fortunately I only need to remove the enforcement of the strict mode from the script file, but not from the tsconfig.json files. I've reset the value to true.
kruplm
force-pushed
the
fdc3-2_0-conformance-nodejs22-upgrade
branch
from
48d5eb5 to
8f31fd8
Compare
kruplm
force-pushed
the
fdc3-2_0-conformance-nodejs22-upgrade
branch
from
8f31fd8 to
e44335b
Compare
psmulovics
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades packages and CI workflows to build on Node.js 22.
Node.js 22 has replaced the 'assert' syntax with 'with'
which had an impact on the packaging for 2 of our libraries:
Changes in this PR: