Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/streamline testplan report - part 1 #1163

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

zhenyu-ms
Copy link
Contributor

@zhenyu-ms zhenyu-ms commented Dec 24, 2024

Bug / Requirement Description

reduce the size of generated report files

Solution description

  • remove unused report entry attributes
    • fix_spec_path, host
    • status_override, status_reason if empty (what's their use case?)
    • depending on report cat, env_status, part or strict_order
    • depending on --code enabled, line_no, code_context & file_path
  • remove unused assertion entry attributes
    • merge utc_time & machine_time into timestamp (in unix format) and store tz info in nearest test-level report under key timezone
    • omit DEFAULT category & flag
  • introduce date-fns/tz, upgrade date-fns accordingly

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

@zhenyu-ms zhenyu-ms marked this pull request as ready for review January 2, 2025 09:46
@zhenyu-ms zhenyu-ms requested a review from a team as a code owner January 2, 2025 09:46
if (selectedEntry.timer && selectedEntry.timer.run) {
if (links[0].utc_time) {
let previousEntryTime = null;
// TODO: remove the else branch after Aug. 1 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing

@@ -260,6 +256,15 @@ const GetCenterPane = (

/** TODO */
const getAssertions = (selectedEntries, displayTime, UTCTime) => {
// get timezone from nearest (test-level) report
let IANAtz = ""; // default to utc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const IANAtz = selectedEntries.find(e => e.timezone)?.timezone || "";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants