-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/streamline testplan report - part 1 #1163
base: main
Are you sure you want to change the base?
Conversation
- remove unused entries from generated report - merge utc_time & machine_time into timestamp field
e141614
to
47b0da7
Compare
57444c5
to
9759572
Compare
16ec437
to
a701b89
Compare
if (selectedEntry.timer && selectedEntry.timer.run) { | ||
if (links[0].utc_time) { | ||
let previousEntryTime = null; | ||
// TODO: remove the else branch after Aug. 1 2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure thing
@@ -260,6 +256,15 @@ const GetCenterPane = ( | |||
|
|||
/** TODO */ | |||
const getAssertions = (selectedEntries, displayTime, UTCTime) => { | |||
// get timezone from nearest (test-level) report | |||
let IANAtz = ""; // default to utc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const IANAtz = selectedEntries.find(e => e.timezone)?.timezone || "";
03bf37e
to
5ba34e5
Compare
Bug / Requirement Description
reduce the size of generated report files
Solution description
--code
enabled, line_no, code_context & file_pathChecklist: