Avoid "no such packet" errors on outgoingClearMessageId.

moscajs · Jul 8, 2016 · e161a3c · e161a3c
1 parent 84e7a6e
commit e161a3c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/abstract.js b/abstract.js
@@ -709,6 +709,17 @@ function abstractPersistence (opts) {
       })
     })
   })
+
+  testInstance('do not error if unkown messageId in outoingClearMessageId', function (t, instance) {
+    var client = {
+      id: 'abc-123'
+    }
+
+    instance.outgoingClearMessageId(client, 42, function (err) {
+      t.error(err)
+      instance.destroy(t.end.bind(t))
+    })
+  })
 }
 
 module.exports = abstractPersistence
diff --git a/persistence.js b/persistence.js
@@ -203,7 +203,7 @@ MemoryPersistence.prototype.outgoingClearMessageId = function (client, packet, c
     }
   }
 
-  cb(new Error('no such packet'))
+  cb()
 }
 
 MemoryPersistence.prototype.outgoingStream = function (client) {
-Original file line number
+Diff line change
@@ Expand Up @@
         }
       }
-      cb(new Error('no such packet'))
+      cb()
     }
     MemoryPersistence.prototype.outgoingStream = function (client) {
@@ Expand Down @@