basti/nativeMessaging #10196
Open
basti/nativeMessaging #10196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcleinman
reviewed
Jan 22, 2025
|
|
||
| #[cfg(target_os = "windows")] | ||
| mod launcher { | ||
| const CLIENT_PATH: &str = "C:\\Program Files\\Mozilla\\Mozilla VPN\\Mozilla VPN.exe"; |
There was a problem hiding this comment.
is there any way it's ever installed to a different directory?
There was a problem hiding this comment.
As we don't offer other ways of installation, no :)
mcleinman
approved these changes
Jan 22, 2025
oskirby
approved these changes
Jan 30, 2025
|
|
||
| } | ||
|
|
||
| #[cfg(not(target_os = "windows"))] |
There was a problem hiding this comment.
After doing a bit of Googling, I think the way to handle this on Linux would be to use a deep-link to try and launch the VPN client. This could then be invoked using the xdg-open tool. A similar approach could also be done on Windows too, but the invocation would be different.
This is not a request to change anything here, we can tackle that in a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR "fixes" "the "bridge_pong" - the extension and client only expect that we pass json-objects through this impl, the native messaging part however expected a raw string. - This now gives nm the ability to handle commands similar to the client.
Then i add a start command that launches on windows the client. Feedback welcome if there is a "standard" way to that on linux os'es too.