Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update e2e tests to run on new canvas (no-changelog) #12784

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

alexgrozav
Copy link
Member

@alexgrozav alexgrozav commented Jan 22, 2025

Summary

  • Disabled 43 tests out of 321 tests, which means 87% of our tests are passing.
  • Change test command for old canvas to dev:e2e:v1 and test:e2e:dev:v1

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-539/switch-e2e-tests-to-run-on-new-canvas

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

const workflowPage = new WorkflowPage();
const ndv = new NDV();

export const simpleWebhookCall = (options: SimpleWebhookCallOptions) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted out of webhooks tests. The tests were running multiple times due to importing.

cypress/e2e/10-undo-redo.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/10-undo-redo.cy.ts Outdated Show resolved Hide resolved
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

netroy
netroy previously approved these changes Jan 23, 2025
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tentative approval

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jan 23, 2025

n8n    Run #8899

Run Properties:  status check failed Failed #8899  •  git commit 75f4541d41: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review cat-539-switch-e2e-tests-to-run-on-new-canvas
Run status status check failed Failed #8899
Run duration 05m 15s
Commit git commit 75f4541d41: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 4
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 324
View all changes introduced in this branch ↗︎

Tests for review

Failed  12-canvas.cy.ts • 2 failed tests

View Output Video

Test Artifacts
Canvas Node Manipulation and Navigation > should render connections correctly if unkown nodes are present Test Replay Screenshots Video
Canvas Node Manipulation and Navigation > Canvas Zoom Functionality > should zoom using scroll or pinch gesture Test Replay Screenshots Video
Failed  5-ndv.cy.ts • 1 failed test

View Output Video

Test Artifacts
NDV > can link and unlink run selectors between input and output Screenshots Video
Failed  39-projects.cy.ts • 1 failed test

View Output Video

Test Artifacts
Projects > when starting from scratch > should move resources between projects Test Replay Screenshots Video
Failed  25-stickies.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  24-ndv-paired-item.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 37 specs in Cypress Cloud.

@alexgrozav alexgrozav requested a review from netroy January 23, 2025 09:37
netroy
netroy previously approved these changes Jan 23, 2025
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tentative approval

@alexgrozav alexgrozav self-assigned this Jan 23, 2025
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

netroy
netroy previously approved these changes Jan 23, 2025
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants