Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tracing=False no longer working #309

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

Butanium
Copy link
Contributor

@Butanium Butanium commented Dec 14, 2024

fixes #308

@Butanium
Copy link
Contributor Author

Butanium commented Dec 14, 2024

Btw no idea what you're doing with this custom backend, but this test

with tiny_model.trace(tiny_input):
won't work in 0.4 as it uses .value but somehow works due to the custom backend.
Therefore I'm unsure how to write a test for this tracing=False behavior

@JadenFiotto-Kaufman
Copy link
Member

@Butanium Can you just add a check like:

if isinstance(output, Proxy):
    output = output.value

Theres an option to turn off the automatic value injection (or with different backends), so if thats off id like this to still return the real value. After that ill merge it in thanks!!

@Butanium
Copy link
Contributor Author

done!

@JadenFiotto-Kaufman JadenFiotto-Kaufman merged commit 28ffff0 into ndif-team:0.4 Dec 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants