storcon: signal LSN wait to pageserver during live migration #10452
+193
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladLazar
force-pushed
the
vlad/migration-wait-lsn
branch
from
c0a9d24 to
53767db
Compare
VladLazar
changed the title
7370 tests run: 6985 passed, 0 failed, 385 skipped (full report)Flaky tests (8)Postgres 17
Postgres 16
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
f797495 at 2025-01-22T14:29:24.504Z :recycle: |
Problem We've seen the ingest connection manager get stuck shortly after a migration. Summary of Changes A speculative mitigation is to use the same mechanism as get page requests for kicking LSN ingest. The connection manager monitors LSN waits and queries the broker if no updates are received for the timeline.
VladLazar
force-pushed
the
vlad/migration-wait-lsn
branch
from
53767db to
191294e
Compare
VladLazar
requested review from
erikgrinaker and
jcsp
and removed request for
erikgrinaker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We've seen the ingest connection manager get stuck shortly after a
migration.
Summary of changes
A speculative mitigation is to use the same mechanism as get page
requests for kicking LSN ingest. The connection manager monitors
LSN waits and queries the broker if no updates are received for the
timeline.
Closes #10351