Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/18518-add-hostname-meta-tag' int…
Browse files Browse the repository at this point in the history
…o 18518-add-hostname-meta-tag

# Conflicts:
#	netbox/dcim/models/devices.py
  • Loading branch information
bctiemann committed Jan 28, 2025
2 parents a398ccf + 62cf4b5 commit 7b88423
Showing 1 changed file with 25 additions and 0 deletions.
25 changes: 25 additions & 0 deletions netbox/dcim/models/devices.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
from django.utils.safestring import mark_safe
from django.utils.translation import gettext_lazy as _

from core.models import ObjectType
from dcim.choices import *
from dcim.constants import *
from dcim.fields import MACAddressField
Expand Down Expand Up @@ -1523,9 +1524,33 @@ class Meta:
def __str__(self):
return str(self.mac_address)

def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)

# Denote the original assigned object (if any) for validation in clean()
self._original_assigned_object_id = self.__dict__.get('assigned_object_id')
self._original_assigned_object_type_id = self.__dict__.get('assigned_object_type_id')

@cached_property
def is_primary(self):
if self.assigned_object and hasattr(self.assigned_object, 'primary_mac_address'):
if self.assigned_object.primary_mac_address and self.assigned_object.primary_mac_address.pk == self.pk:
return True
return False

def clean(self, *args, **kwargs):
super().clean()
if self._original_assigned_object_id and self._original_assigned_object_type_id:
assigned_object = self.assigned_object
ct = ObjectType.objects.get_for_id(self._original_assigned_object_type_id)
original_assigned_object = ct.get_object_for_this_type(pk=self._original_assigned_object_id)

if original_assigned_object.primary_mac_address:
if not assigned_object:
raise ValidationError(
_("Cannot unassign MAC Address while it is designated as the primary MAC for an object")
)
elif original_assigned_object != assigned_object:
raise ValidationError(
_("Cannot reassign MAC Address while it is designated as the primary MAC for an object")
)

0 comments on commit 7b88423

Please sign in to comment.