Fixes: #17070 - Make image_width and image_height read_only on REST API ImageAttachmentSerializer #17234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bctiemann
added
the
type: feature
jeremystretch
deleted the
17070-rest-api-make-image-width-height-read-only
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17070 - Make image_width and image_height read_only on REST API ImageAttachmentSerializer
Sets the
image_widthandimage_heightfields onImageAttachmentSerializerto read_only. This prevents redundant and cumbersome "field required" errors when submitting an Image Attachment via the REST API.Tested to verify that submitting an image via the API without these fields in the payload is still handled correctly via Django and the fields are automatically populated.