Fixes: #18241 - Script results log_threshold should default to Default #18501
+14
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LevelChoices to LOG_DEFAULT and setup the html template to put (All) in the last one
bctiemann
reviewed
Jan 27, 2025
| @@ -162,12 +162,12 @@ class LogLevelChoices(ChoiceSet): | |||
| LOG_FAILURE = 'failure' | |||
|
|
|||
| CHOICES = ( | |||
| (LOG_DEBUG, _('Debug'), 'teal'), | |||
There was a problem hiding this comment.
Why is this changed? I think the ordering is supposed to be of increasing severity. Also this should stay consistent with the order of the constants above and in LOG_LEVEL_RANK.
Is there something gained by changing the order here and the .first to .last in the template?
bctiemann
reviewed
Jan 28, 2025
| @@ -1315,17 +1315,17 @@ def get_table(self, job, request, bulk_actions=True): | |||
| index = 0 | |||
|
|
|||
| try: | |||
| log_threshold = LOG_LEVEL_RANK[request.GET.get('log_threshold', LogLevelChoices.LOG_DEBUG)] | |||
There was a problem hiding this comment.
Were these supposed to be changed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18241 - Script results log_threshold should default to Default
Choicesorder, puttingLOG_DEBUGin the last position.script_result.htmldropdown to add the string(All)only to the last possition following the newLogLevelChoicesorderScriptResultViewget method to returnlog_thresholdwithLOG_DEFAULTinstead ofLOG_DEBUG