Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

18535 skip incompatible plugins #18536

Closed
wants to merge 121 commits into from
Closed

18535 skip incompatible plugins #18536

wants to merge 121 commits into from

Conversation

bctiemann
Copy link
Contributor

Closes: #18535

Changes the behavior of the PluginConfig.validate method so that if a plugin with incompatible min or max version specified, it raises an IncompatiblePluginError which is caught in settings.py and registering the plugin is skipped, allowing NetBox to launch cleanly with the plugin disabled.

jeremystretch and others added 30 commits January 6, 2025 14:02
@jeremystretch
Merge pull request #18308 from netbox-community/feature
ab0a1f0 
Prep for v4.2.0 release
@jeremystretch
Closes #13366: Update documentation for main branch (#18309)
b761097 
* Closes #13366: Update documentation for main branch

* Clarify wording
@jeremystretch
Release v4.2.0
9d82a66
@jeremystretch
Closes #18311: Update minimum required version of PostgreSQL
14cec51
@github-actions
Update source translation strings
ed54122
@jeremystretch
Fixes #18318: Correct navigation breadcrumbs for module type UI view
9c960c2
@jeremystretch
Fixes #18324: Correct filter names for certain related object listings
ef6c89e
@tobiasge @jeremystretch
Fix #18314: Use get to avoid KeyError
4ae5529
@bctiemann
Fixes: #18316 - Fix PrefixIndex reference to 'site' (#18322)
e518f08 
* Fix PrefixIndex reference to 'site'

* Fix ClusterIndex reference to 'site' and add 'scope' to WirelessLANIndex
@github-actions
Update source translation strings
ffac097
@jeremystretch
Fixes #18329: Pin strawberry-graphql-django to v0.52.0 to resolve ups…
53aa2c8 
…tream bug
@bctiemann @jeremystretch
Change PrefixTable.vlan to represent the VLAN ID rather than the VLAN…
4456c48 
… object, to enable more useful sorting by VLAN ID rather than site-grouped VLAN objects
@bctiemann @jeremystretch
Use order_by to change ordering behavior of VLAN column rather than c…
f6b8c19 
…hanging accessor
@jeremystretch
Release v4.2.1 (#18346)
d04fc11 
* Release v4.2.1

* Add changelog for #18282
@github-actions
Update source translation strings
4090afb
@bctiemann @jeremystretch
Update docs to indicate PostgreSQL 13+ requirement
80e1fd0
@jeremystretch
Closes #18362: Create a system job for census reporting
b11f179
@jeremystretch
Fixes #18363: Fix assignment of MAC addresses to interfaces via REST …
b12c8c8 
…API (#18367)

* Fixes #18363: Fix assignment of MAC addresses to interfaces via REST API

* Add missing API & view tests
@jeremystretch
Fixes #18368: Restore missing fields on REST API serializer for MAC a…
571f604 
…ddresses
@bctiemann @jeremystretch
Don't cache CACHE_KEY_CATALOG_ERROR if ISOLATED_DEPLOYMENT is True
32422d1
@github-actions
Update source translation strings
a79d869
@jeremystretch
Fixes #18376: Include tagged VLANs in interfaces list for Q-in-Q inte…
e75d327 
…rfaces
@jeremystretch
Closes #18348: Disable legacy pre-commit hook script
a75fa53
@bctiemann
Fixes: #18350 - Remove 'site' and 'provider_network' from CircuitTerm…
c3efa21 
…inationIndex.display_attrs (#18351)

* Remove 'site' and 'provider_network' from CircuitTerminationIndex.display_attrs

* Use '_site' and '_provider_network' in display_attrs

* Replace private fields with 'termination'
@bctiemann
Fixes: #18373 - Fix validation of site in Assign Device to Cluster fl…
993d8f1 
…ow (#18375)

* Fix validation of site in Assign Device to Cluster flow

* Validate Location as well as Site scope
@bctiemann
Fixes: #18336 - Perform Rack object validation of u_height and starti…
4a1fea3 
…ng_unit on rack_type if present (#18395)

* Perform Rack object validation of u_height and starting_unit on rack_type if present

* Calculate effective values before doing validation
@bctiemann @jeremystretch
Make GFK scope field sortable=False on tables where it appears
07ad4c1
@bctiemann @jeremystretch
Migrate DEFAULT_FILE_STORAGE to STORAGES
50b7f46
@jeremystretch
Fixes #18379: Ensure RSS feed content within dashboard widget is sani…
a9f3c74 
…tized
@jeremystretch
Closes #18425: Remove the triage priority field from GitHub issue tem…
4a13664 
…plates
jeremystretch and others added 28 commits January 29, 2025 18:23
@jeremystretch @bctiemann
Closes #18425: Remove the triage priority field from GitHub issue tem…
ff565ab 
…plates
@jeremystretch @bctiemann
Fixes #18392: Exclude config contexts assigned to locations for VMs
8cc9a5a
@atownson @jeremystretch @bctiemann
Fixes: #18369 - Remove the json filter for protection rules (#18388)
39cd8bc 
* Remove the json filter for protection rules

* Configure PROTECTION_RULE config attribute to use ConfigJSONEncoder as serializer

* Tweak getattr()

---------

Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
@jeremystretch @bctiemann
Release v4.2.2
3aaf344
@github-actions @bctiemann
Update source translation strings
58224bb
@DanSheps @bctiemann
Fixes: #18433 - Fix missing is_primary property on MACAddress model
cf685ff
@DanSheps @bctiemann
Change to @cached_property
61c7702
@jeremystretch @bctiemann
Fixes #18438: Specify batch_size for migrations which run bulk_update()
b25ffc3
@DanSheps @bctiemann
Update UI to disable interface assignment when assigned as primary
7a13113
@DanSheps @bctiemann
Fixes: #18447 - Fix sorting by mac_address field
b8370c5 
* Disable sorting by `mac_address` for legacy `mac_address` field for Device and VM Interfaces
* Ensure `primary_mac_address` field is included in field list for Device and VM Interfaces
@DanSheps @bctiemann
Update VirtualMachineVMInterfaceTable
2038cc9
@DanSheps @bctiemann
Remove mac_address from tables.
80e17c6
@DanSheps @bctiemann
Fixes: #18449 - Clean up some formatting errors
cee1050
@github-actions @bctiemann
Update source translation strings
2c443e0
@bctiemann
Add warning about UTF8 encoding in PostgreSQL
9e37b0d
@bctiemann
Add note about \l command
b446671
@bctiemann
Fix typo in Site Groups docs
0f009fb
@jeremystretch @bctiemann
Assign GitHub issue type on creation
f8d296e
@jeremystretch @bctiemann
Closes #18484: Exempt changes to GitHub templates from CI
951dd0f
@jeremystretch @bctiemann
Add remaining issue types
6773072
@github-actions @bctiemann
Update source translation strings
f0b2b43
@bctiemann
Reword references to develop and master branches
2cec964
@bctiemann
NB-717 Update dashboard news feed URL to eliminate multiple 301 redir…
b6ac49e 
…ects
@mr1716 @bctiemann
#18512 Update required-parameters spelling
7e1d66c
@tobiasge @bctiemann
Fix #18515: Don't fail in DEBUG mode
697cb14 
When no Redis server is reachable management commands failed without
this try...except block.
@bctiemann
Add <meta> tag reflecting settings.HOSTNAME
41923b0
@bctiemann
Skip incompatible plugins during startup and remove from PLUGINS
588fa9d
@bctiemann
Merge remote-tracking branch 'origin/18535-skip-incompatible-plugins'…
b4e0c0b 
… into 18535-skip-incompatible-plugins

# Conflicts:
#	netbox/dcim/models/devices.py
@bctiemann bctiemann closed this Jan 29, 2025
@bctiemann bctiemann deleted the 18535-skip-incompatible-plugins branch January 29, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bctiemann @Aurvandill @jeremystretch @tobiasge @atownson @DanSheps @mr1716