Closes: #18535 - Skip incompatible plugins during startup and remove from PLUGINS #18537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bctiemann
commented
Jan 29, 2025
| try: | ||
| plugin_config.validate(PLUGINS_CONFIG[plugin_name], RELEASE.version) | ||
| except IncompatiblePluginError as e: | ||
| print(f'Unable to load plugin {plugin_name}: {e}') |
There was a problem hiding this comment.
I'm not sure about adding a print here, as it would be the first of its kind in this file. Is there a better way to emit this warning?
|
Just to understand, this would print a warning at netbox upgrade time? The experience of figuring out which plugin has a strict max_version specified and breaks the upgrade process even on patch upgrades during the database migration step could really use to be more explanatory. |
|
Yes, it would look like this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #18535
Changes the behavior of the
PluginConfig.validatemethod so that if a plugin with incompatible min or max version specified, it raises anIncompatiblePluginErrorwhich is caught insettings.pyand registering the plugin is skipped, allowing NetBox to launch cleanly with the plugin disabled.