We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi, Our acq functions have implemented the ability to return gradient (https://github.com/novonordisk-research/ProcessOptimizer/blob/762732e84e07859f9460903ffb62584d7059f052/ProcessOptimizer/acquisition.py#L117C1-L119C34). I do not see the neccesity for returning said gradient. If I'm mistaken, then disregard this Issue. Alternatively, I propose that we change the acq.functions (and the corresponding tests).
Without gradients, we will have a more easy approach to implement new acq functions.
The text was updated successfully, but these errors were encountered:
If and when we are to look into new acq functions, this could serve as points of inspiration: scikit-optimize/scikit-optimize#528 (remember to look into if Sobol can be replaced to e.g. scipy or plain old random) nEI looks good in some examples, but can also offer no improvements in other examples: scikit-optimize/scikit-optimize#415, scikit-optimize/scikit-optimize#452) Or this: sustainable-processes/summit#72 Or these/this: https://github.com/kiudee/bayes-skopt/blob/master/bask/acquisition.py
Sorry, something went wrong.
See also: scikit-optimize/scikit-optimize#460
And finally: remember, that there is already greedy A optimum implemented: scikit-optimize/scikit-optimize#432
This seems like some interesting new acq functions that could be looked into: scikit-optimize/scikit-optimize#1156
No branches or pull requests
Hi,
Our acq functions have implemented the ability to return gradient (https://github.com/novonordisk-research/ProcessOptimizer/blob/762732e84e07859f9460903ffb62584d7059f052/ProcessOptimizer/acquisition.py#L117C1-L119C34). I do not see the neccesity for returning said gradient. If I'm mistaken, then disregard this Issue.
Alternatively, I propose that we change the acq.functions (and the corresponding tests).
Without gradients, we will have a more easy approach to implement new acq functions.
The text was updated successfully, but these errors were encountered: