[azfarulmatin] IP #70

azfarulmatin · 2023-09-05T04:07:40Z

No description provided.

ryanlohyr

Overall great job but some improvements to work on:)

ryanlohyr · 2023-09-07T09:48:13Z

src/main/java/Duke.java

+        // Check for any inputs with '/'
+        int checkSlash = userInput.indexOf("/");
+        if (checkSlash != -1) {
+            description = userInput.substring(type.length() + 1, checkSlash).trim();


Could this be refactored into a function? As we repeat it twice

ryanlohyr · 2023-09-07T09:49:34Z

src/main/java/Duke.java

+            userInput = scanner.nextLine();
+            System.out.println(LINE);
+
+            if (userInput.equals("bye")) {


could this be refactored into a switch statement for better readability?

ryanlohyr · 2023-09-07T09:50:40Z

src/main/java/Duke.java

+            String by = bracketInfo.replace("/by", "").trim();
+            tasks[count] = new Deadline(description, by);
+        } else if (type.equals("Event")) {
+            String from = bracketInfo.split("/from")[1].split("/to")[0].trim();


The code is relatively concise, but it might benefit from some additional comments or variable names to make it more self-explanatory. For example, you could define variables with more descriptive names for the split values.

ryanlohyr · 2023-09-07T09:53:07Z

src/main/java/Duke.java

+    @Override
+    public String toString() {
+        return "[D]"
+                + super.toString()


The code uses string concatenation to build the final string for the object's representation. While this approach works, it can be a bit less readable, especially when dealing with multiple string elements. Consider using String.format() for improved readability and performance.

janelleenqi

Overall, GOOD JOB! There are some minor changes you can make for readability and organisation (using a switch statement sounds good!). You did well commenting each function and following the naming conventions!

janelleenqi · 2023-09-07T10:09:23Z

src/main/java/Duke.java

+        this.description = description;
+        this.isDone = false;
+    }
+    public void markAsDone() {


you can consider spacing out (added new lines between) your functions for better readability

janelleenqi · 2023-09-07T10:10:37Z

src/main/java/Duke.java

+    }
+}
+
+class Deadline extends Task {


having a new file for each class can keep your code more organised (abstraction)

janelleenqi · 2023-09-07T10:11:48Z

src/main/java/Duke.java

+    }
+    public void markAsUndone() {
+        isDone = false;
+    }


you can consider combining this to become a setter method like "void setFound(boolean isFound);"

janelleenqi · 2023-09-07T10:12:43Z

src/main/java/Duke.java

+
+class Task {
+    protected String description;
+    protected boolean isDone;


You did well in following the naming conventions (PascalCase for class and camelCase for variables)!!

janelleenqi · 2023-09-07T10:16:59Z

src/main/java/Duke.java

+        }
+    }
+
+    // Mark a task as done


Great job in explicitly commenting on the purpose of functions you added!

NaychiMin

Overall, your coding quality is very good, just small minor suggestions, not errors! Keep it up! 💯

NaychiMin · 2023-09-07T10:24:18Z

src/main/java/Duke.java

+            return "[X] "
+                    + description;


Any reason for separating it on different lines? It's a rather short line :)

NaychiMin · 2023-09-07T10:28:11Z

src/main/java/Duke.java

+    // Create a task of a specific type to the tasks array
+    private static void addTask(String userInput, Task[] tasks, int count, String type) {
+        String description;
+        String bracketInfo;


Perhaps there might be a better more suggestive naming of the variable?

NaychiMin · 2023-09-07T10:29:04Z

src/main/java/Duke.java

+        String description;
+        String bracketInfo;
+
+        // Check for any inputs with '/'


I like how you added comments for easier readability! 👍

NaychiMin · 2023-09-07T10:29:50Z

src/main/java/Duke.java

+                           + LINE);
+
+        Scanner scanner = new Scanner(System.in);
+        Task[] tasks = new Task[100];


Good job on always having proper naming of functions, classes and variables! 👍

YongbinWang

Overall good job on your ip so far. Coding standard and code quality are alright. Try to structure your classes such that it only does one specific role. For example, your exceptions should be separated from your duke class. Keep up the good work!

YongbinWang · 2023-09-16T08:33:40Z

src/main/java/duke/Duke.java

+    public void run() {
+        String LINE = "__________________________________________\n";
+        System.out.println(LINE
+                           + "Hello I'm MatinBot\n"
+                           + "What can I do for you?\n"
+                           + LINE);
+
+        Scanner scanner = new Scanner(System.in);
+        Task[] tasks = new duke.Task[100];
+        int count = 0;
+        String userInput;
+
+        while (true) {
+            // Get the user input first
+            userInput = scanner.nextLine();
+            System.out.println(LINE);
+
+            try {
+                if (userInput.equals("bye")) {
+                    break;
+                } else if (userInput.equals("list")) {
+                    printTasks(tasks, count);
+                } else if (userInput.startsWith("mark")) {
+                    markTask(userInput, tasks, count);
+                } else if (userInput.startsWith("unmark")) {
+                    unmarkTask(userInput, tasks, count);
+                } else if (userInput.startsWith("todo")) {
+                    String description = userInput.replaceFirst("todo", "").trim();
+                    if (description.isEmpty()) {
+                        throw new EmptyDescriptionException("todo");
+                    }
+                    addTask("todo " + description, tasks, count, "todo");
+                    count++;
+                } else if (userInput.startsWith("deadline")) {
+                    String description = userInput.replaceFirst("deadline", "").trim();
+                    if (description.isEmpty()) {
+                        throw new EmptyDescriptionException("deadline");
+                    }
+                    // Check for /by in the description
+                    if (!description.contains("/by")) {
+                        System.out.println("☹ OOPS!!! The deadline task must include '/by' to specify the date.");
+                    } else {
+                        addTask("deadline " + description, tasks, count, "deadline");
+                        count++;
+                    }
+                } else if (userInput.startsWith("event")) {
+                    String description = userInput.replaceFirst("event", "").trim();
+                    if (description.isEmpty()) {
+                        throw new EmptyDescriptionException("event");
+                    }
+                    // Check for /from and /to in the description
+                    if (!description.contains("/from") || !description.contains("to")) {
+                        System.out.println("☹ OOPS!!! The event task must include '/from' and '/to' to specify the date range.");
+                    } else {
+                        addTask("event " + description, tasks, count, "event");
+                        count++;
+                    }
+                } else {
+                    throw new UnknownCommandException();
+                }
+            } catch (EmptyDescriptionException e) {
+                System.out.println(e.getMessage());
+            } catch (UnknownCommandException e) {
+                System.out.println(e.getMessage());
+            }
+            System.out.println(LINE);
+        }
+
+        System.out.println("Bye. Hope to see you again soon!\n" + LINE);
+        scanner.close();
+    }


Consider abstracting away some of the heavy logic to reduce long methods. Generally more than 30 lines is too long.

YongbinWang · 2023-09-16T08:35:48Z

src/main/java/duke/Duke.java

+
+        Scanner scanner = new Scanner(System.in);
+        Task[] tasks = new duke.Task[100];
+        int count = 0;


Consider using a more suitable variable name to keep track of your number of tasks.

YongbinWang · 2023-09-16T08:36:45Z

src/main/java/duke/Duke.java

+        switch (type) {
+            case "todo":


Violation of coding standard here, there should not be an indentation for the case clause.

… to a string format to save

# Conflicts: # src/main/java/duke/Duke.java

azfarulmatin added 10 commits September 5, 2023 11:55

Add chatbot message

326786b

Add level 1

942c0c4

Add and list

c971713

Mark as done

1eef87b

Add the ability to echo commands

ab74f0a

Add list function for user to store tasks

b8c0f92

Add the ability to mark tasks as done

d668a45

Tweak the code to comply with a coding standard

ad137e5

Add support for tracking todo, deadlines and events

7ffd63c

Improve code quality

62bc7a5

ryanlohyr reviewed Sep 7, 2023

View reviewed changes

janelleenqi reviewed Sep 7, 2023

View reviewed changes

NaychiMin reviewed Sep 7, 2023

View reviewed changes

azfarulmatin added 6 commits September 15, 2023 12:46

Handle errors for todo

2c6d3b6

Handle errors for todo event and deadline

aa236d0

Fix bugs for spacebar error

a3b8c95

Divide classes into packages

47c7370

Fix bugs for task list quantity

7d2298f

Fix bugs for marking and unmarking of tasks.

8b22a82

YongbinWang reviewed Sep 16, 2023

View reviewed changes

azfarulmatin added 10 commits September 19, 2023 11:13

Add support for deleting tasks from list

7380c55

Create a method to parse a string into a Task object and convert task…

2da4d1d

… to a string format to save

Save task into the harddisk automatically whenever there are changes

31bc5a8

FIx bugs

327f29d

Merge branch 'branch-Level-6'

87d459f

Merge branch 'branch-Level-7'

8b28585

# Conflicts: # src/main/java/duke/Duke.java

Add jar manifest

4721aee

Refactor the code to separate classes

9e5e42d

Fix bugs for delete task

80dd827

Fix bugs when trying to save Deadline task

db3d7b7

azfarulmatin and others added 5 commits October 6, 2023 21:48

Add find function

2a15cd2

Add JavaDoc comments to the code

1b5de63

Update README.md

a369c08

A-UserGuide

b62c924

Fix bugs for txt file location

d5a00ce

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[azfarulmatin] IP #70

[azfarulmatin] IP #70

azfarulmatin commented Sep 5, 2023

ryanlohyr left a comment

ryanlohyr Sep 7, 2023

ryanlohyr Sep 7, 2023

ryanlohyr Sep 7, 2023

ryanlohyr Sep 7, 2023

janelleenqi left a comment

janelleenqi Sep 7, 2023

janelleenqi Sep 7, 2023

janelleenqi Sep 7, 2023

janelleenqi Sep 7, 2023

janelleenqi Sep 7, 2023

NaychiMin left a comment

NaychiMin Sep 7, 2023

NaychiMin Sep 7, 2023

NaychiMin Sep 7, 2023

NaychiMin Sep 7, 2023

YongbinWang left a comment

YongbinWang Sep 16, 2023

YongbinWang Sep 16, 2023

YongbinWang Sep 16, 2023

[azfarulmatin] IP #70

Are you sure you want to change the base?

[azfarulmatin] IP #70

Conversation

azfarulmatin commented Sep 5, 2023

ryanlohyr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janelleenqi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NaychiMin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YongbinWang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment