Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefetch in do_move() #5770

Closed
wants to merge 1 commit into from
Closed

Conversation

ces42
Copy link
Contributor

@ces42 ces42 commented Jan 12, 2025

this allows removing Position::key_after()

STC
LLR: 2.93 (-2.94,2.94) <-1.75,0.25>
Total: 24960 W: 6556 L: 6336 D: 12068
Ptnml(0-2): 59, 2554, 7056, 2730, 81

LTC
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 115080 W: 29319 L: 29204 D: 56557
Ptnml(0-2): 51, 10736, 35864, 10825, 64

STC with 2MB hash
LLR: 3.04 (-2.94,2.94) <-1.75,0.25>
Total: 182176 W: 46998 L: 46932 D: 88246
Ptnml(0-2): 526, 19711, 50544, 19785, 522

LTC with 8MB hash
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 441180 W: 111557 L: 111746 D: 217877
Ptnml(0-2): 229, 39698, 140929, 39501, 233

all of the tests were against c76c179

bench: 1379150

this allows removing Position::key_after()

bench: 1379150
Copy link

clang-format 18 needs to be run on this PR.
If you do not have clang-format installed, the maintainer will run it when merging.
For the exact version please see https://packages.ubuntu.com/noble/clang-format-18.

(execution 12737663706 / attempt 1)

@mstembera
Copy link
Contributor

I wonder if this is more consequential in cases where we are memory bound. i.e., on big NUMA hardware for which we had to write patches like this #5515

@vondele
Copy link
Member

vondele commented Jan 18, 2025

I doubt TT access is still significant compared to the memory pressure related to NNUE, so I can see this is no longer needed

@vondele vondele added simplification A simplification patch to be merged Will be merged shortly labels Jan 18, 2025
@vondele vondele closed this in aaafaae Jan 18, 2025
@mstembera
Copy link
Contributor

I think the memory pressure from NNUE can affect it but TT accesses are more about latency while NNUE is more about bandwidth/throughput.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
simplification A simplification patch to be merged Will be merged shortly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants